[LLDB] Add PDB/calling-conventions.test for Arm/Windows

[omjavaid]

Summary

This patch renames PDB/calling-conventions.test to calling-conventions-x86.test.
Also restrict it to run only for target-x86*.
This patch also adds a arm specific test PDB/calling-conventions-arm.test which
tests that x86 specifc calling convention decorators are ignored by Arm compiler.

[mstorsjo]

There's consistent typos about the test name in the commit subject and description.

lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test

2

Hmm, I wasn't aware of the fact that you can do such || expressions in the REQUIRES line - I presume you've verified that this test actually does get picked up and executed?

3

Here, there's probably no need to force it to 32 bit mode - unless we expect to have a similar test for the undecorated mangling in aarch64 and x86_64 mode too?

[omjavaid]

lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test

2

This is tested on both Arm/Windows and x86/Windows.

3

Mangling is specific to x86 32 bit only. All other configs shouldnt do it. I guess we can test it for both 64bit and 32bit arm. Let me update my change.

[omjavaid]

Added test for AArch64 and x64 calling conventions.

[labath]

It seems like this is not actually running the code. Can we make it such that these tests are conditional on the appropriate llvm targets being enabled (instead of the host being of a specific type)?

[mstorsjo]

Thanks, this looks more complete and consistent to me now!

In D128678#3615531, @labath wrote:

It seems like this is not actually running the code. Can we make it such that these tests are conditional on the appropriate llvm targets being enabled (instead of the host being of a specific type)?

Well it does need being able to link executables for these targets, which you generally can't rely on I think? (I don't think the %build macro in general works as a cross compiler?)

[omjavaid]

In D128678#3616685, @mstorsjo wrote:

Thanks, this looks more complete and consistent to me now!

In D128678#3615531, @labath wrote:

It seems like this is not actually running the code. Can we make it such that these tests are conditional on the appropriate llvm targets being enabled (instead of the host being of a specific type)?

Well it does need being able to link executables for these targets, which you generally can't rely on I think? (I don't think the %build macro in general works as a cross compiler?)

We can compile the test on linux as it doesnt require any libraries i-e --nodefaultlib. However its MS DIA SDK based PDB test which is only available on system windows. NATIVE PDB reader tests are already being run independently.

[labath]

In D128678#3616685, @mstorsjo wrote:

Thanks, this looks more complete and consistent to me now!

In D128678#3615531, @labath wrote:

It seems like this is not actually running the code. Can we make it such that these tests are conditional on the appropriate llvm targets being enabled (instead of the host being of a specific type)?

Well it does need being able to link executables for these targets, which you generally can't rely on I think? (I don't think the %build macro in general works as a cross compiler?)

What Omair said. And, generally speaking, I'm not convinced of the usefulness of the %build script. It lacked sufficient buy-in from the start is now pretty much exclusively used for windows tests. It supports both cross-compilation and host-compilation modes, but it's very inconsistent about which one it uses for a particular combination of flags and compilers.
Overall, I don't think we need any kind of scripts for cross-compilation -- we can just issue appropriate clang and lld commands ourselves. There /might/ be a use case for host-compilation, but I suspect that could also be achieved with more conventional means (a couple of well-placed substitutions).

In D128678#3616753, @omjavaid wrote:

However its MS DIA SDK based PDB test which is only available on system windows. NATIVE PDB reader tests are already being run independently.

Ok, that makes sense. Thanks.

[omjavaid]

@labath @mstorsjo ok to land?

lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test

+REQUIRES: system-windows, lld, (target-arm || target-aarch64) 
+RUN: %build --compiler=clang-cl --arch=32 --nodefaultlib --output=%t.exe %S/Inputs/CallingConventionsTest.cpp
+RUN: %build --compiler=clang-cl --arch=64 --nodefaultlib --output=%t.exe %S/Inputs/CallingConventionsTest.cpp
+RUN: lldb-test symbols -dump-ast %t.exe | FileCheck %s
+
+CHECK: Module: {{.*}}
+CHECK-DAG: int (*FuncCCallPtr)();
+CHECK-DAG: int (*FuncStdCallPtr)();
+CHECK-DAG: int (*FuncFastCallPtr)();
+CHECK-DAG: int (*FuncVectorCallPtr)();
+CHECK-DAG: int (S::*FuncThisCallPtr)();

lldb/test/Shell/SymbolFile/PDB/calling-conventions-x86.test

+REQUIRES: system-windows, lld, (target-x86 || target-x86_64) 
+RUN: %build --compiler=clang-cl --arch=32 --nodefaultlib --output=%t.exe %S/Inputs/CallingConventionsTest.cpp \
+RUN:  && lldb-test symbols -dump-ast %t.exe | FileCheck --check-prefix 32BIT-CHECK %s
+RUN: %build --compiler=clang-cl --arch=64 --nodefaultlib --output=%t.exe %S/Inputs/CallingConventionsTest.cpp \
+RUN:  && lldb-test symbols -dump-ast %t.exe | FileCheck --check-prefix 64BIT-CHECK %s
+
+64BIT-CHECK: Module: {{.*}}
+64BIT-CHECK-DAG: int (*FuncCCallPtr)();
+64BIT-CHECK-DAG: int (*FuncStdCallPtr)();
+64BIT-CHECK-DAG: int (*FuncFastCallPtr)();
+64BIT-CHECK-DAG: int (*FuncVectorCallPtr)() __attribute__((vectorcall));
+64BIT-CHECK-DAG: int (S::*FuncThisCallPtr)();
+
+32BIT-CHECK: Module: {{.*}}
+32BIT-CHECK-DAG: int (*FuncCCallPtr)();
+32BIT-CHECK-DAG: int (*FuncStdCallPtr)() __attribute__((stdcall));
+32BIT-CHECK-DAG: int (*FuncFastCallPtr)() __attribute__((fastcall));
+32BIT-CHECK-DAG: int (*FuncVectorCallPtr)() __attribute__((vectorcall));
+32BIT-CHECK-DAG: int (S::*FuncThisCallPtr)() __attribute__((thiscall));

lldb/test/Shell/SymbolFile/PDB/calling-conventions.test

-REQUIRES: system-windows, lld
-RUN: %build --compiler=clang-cl --arch=32 --nodefaultlib --output=%t.exe %S/Inputs/CallingConventionsTest.cpp
-RUN: lldb-test symbols -dump-ast %t.exe | FileCheck %s
-
-CHECK: Module: {{.*}}
-CHECK-DAG: int (*FuncCCallPtr)();
-CHECK-DAG: int (*FuncStdCallPtr)() __attribute__((stdcall));
-CHECK-DAG: int (*FuncFastCallPtr)() __attribute__((fastcall));
-CHECK-DAG: int (*FuncVectorCallPtr)() __attribute__((vectorcall));
-CHECK-DAG: int (S::*FuncThisCallPtr)() __attribute__((thiscall));