[Kaleidoscope] Remove unused function argument

[marcauberer]

Summary

Removes an unused function argument from a code listing in the Kaleidoscope turorial in step 9.

[marcauberer]

Rebase

[dblaikie]

Does a similar change need to be made to any of the actual tutorial markup/markdown/whatever-they-are pages and code snippets found in them?

[marcauberer]

@dblaikie actually yes, I forgot checking that. Will just adjust that and push it again ...

[MaskRay]

In llvm/examples, CreateFunctionType occurs just in Kaleidoscope/Chapter9/toy.cpp. So there is no accompanying text.

[marcauberer]

Adjust tutorial code listing in text section

[marcauberer]

@MaskRay the rst files for generating the website are located under llvm/docs. There was one occurrence there, adjusted it.

[marcauberer]

@MaskRay I have no permission to push the patch. Can you do that for me?

llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl09.rst

 
 .. code-block:: c++
 
   DIScope *FContext = Unit;
   unsigned LineNo = 0;
   unsigned ScopeLine = 0;
   DISubprogram *SP = DBuilder->createFunction(
       FContext, P.getName(), StringRef(), Unit, LineNo,
-      CreateFunctionType(TheFunction->arg_size(), Unit),
+      CreateFunctionType(TheFunction->arg_size()),
       false /* internal linkage */, true /* definition */, ScopeLine,
       DINode::FlagPrototyped, false);
   TheFunction->setSubprogram(SP);
 
 and we now have an DISubprogram that contains a reference to all of our
 metadata for the function.
 
 Source Locations

llvm/examples/Kaleidoscope/Chapter9/toy.cpp

void DebugInfo::emitLocation(ExprAST *AST) {
   if (LexicalBlocks.empty())
     Scope = TheCU;
   else
     Scope = LexicalBlocks.back();
   Builder->SetCurrentDebugLocation(DILocation::get(
       Scope->getContext(), AST->getLine(), AST->getCol(), Scope));
 }
 
-static DISubroutineType *CreateFunctionType(unsigned NumArgs, DIFile *Unit) {
+static DISubroutineType *CreateFunctionType(unsigned NumArgs) {
   SmallVector<Metadata *, 8> EltTys;
   DIType *DblTy = KSDbgInfo.getDoubleTy();
 
   // Add the result type.
   EltTys.push_back(DblTy);
 
   for (unsigned i = 0, e = NumArgs; i != e; ++i)
     EltTys.push_back(DblTy);
Function *FunctionAST::codegen() {
   // Create a subprogram DIE for this function.
   DIFile *Unit = DBuilder->createFile(KSDbgInfo.TheCU->getFilename(),
                                       KSDbgInfo.TheCU->getDirectory());
   DIScope *FContext = Unit;
   unsigned LineNo = P.getLine();
   unsigned ScopeLine = LineNo;
   DISubprogram *SP = DBuilder->createFunction(
       FContext, P.getName(), StringRef(), Unit, LineNo,
-      CreateFunctionType(TheFunction->arg_size(), Unit), ScopeLine,
+      CreateFunctionType(TheFunction->arg_size()), ScopeLine,
       DINode::FlagPrototyped, DISubprogram::SPFlagDefinition);
   TheFunction->setSubprogram(SP);
 
   // Push the current scope.
   KSDbgInfo.LexicalBlocks.push_back(SP);
 
   // Unset the location for the prologue emission (leading instructions with no
   // location in a function are considered part of the prologue and the debugger