This is an archive of the discontinued LLVM Phabricator instance.

[Kaleidoscope] Remove unused function argument
ClosedPublic

Authored by marcauberer on Jun 27 2022, 2:22 AM.

Details

Summary

Removes an unused function argument from a code listing in the Kaleidoscope turorial in step 9.

Diff Detail

Event Timeline

marcauberer created this revision.Jun 27 2022, 2:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 2:22 AM
marcauberer requested review of this revision.Jun 27 2022, 2:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 2:22 AM
marcauberer added a reviewer: Restricted Project.Jun 27 2022, 2:23 AM
marcauberer edited reviewers, added: Wilfred, probinson; removed: Restricted Project.Jun 27 2022, 2:50 AM
dblaikie accepted this revision.Jun 29 2022, 10:46 AM

Does a similar change need to be made to any of the actual tutorial markup/markdown/whatever-they-are pages and code snippets found in them?

This revision is now accepted and ready to land.Jun 29 2022, 10:46 AM

@dblaikie actually yes, I forgot checking that. Will just adjust that and push it again ...

MaskRay accepted this revision.Jun 29 2022, 10:53 AM

In llvm/examples, CreateFunctionType occurs just in Kaleidoscope/Chapter9/toy.cpp. So there is no accompanying text.

Adjust tutorial code listing in text section

@MaskRay the rst files for generating the website are located under llvm/docs. There was one occurrence there, adjusted it.

@MaskRay I have no permission to push the patch. Can you do that for me?

This revision was landed with ongoing or failed builds.Jun 30 2022, 1:47 PM
This revision was automatically updated to reflect the committed changes.