Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

People marcauberer

marcauberer (Marc Auberer)
SAP

Projects

User does not belong to any projects.

User Details

User Since
Jan 30 2022, 10:17 AM (96 w, 6 d)

Recent Activity
View All

Sep 19 2023

marcauberer added inline comments to D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.
Sep 19 2023, 1:37 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.

Add ToDo to cover more cases

Sep 19 2023, 1:36 PM · Restricted Project, Restricted Project

Sep 14 2023

marcauberer added a comment to D159380: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B.

@nikic see https://github.com/llvm/llvm-project/pull/66419

Sep 14 2023, 12:10 PM · Restricted Project, Restricted Project

Sep 12 2023

marcauberer updated the diff for D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.

Rebase

Sep 12 2023, 1:09 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159204: [InstCombine] Baseline tests for folding (A/-B)==(A/B) to (A/B)==0.

Rebase

Sep 12 2023, 1:07 PM · Restricted Project, Restricted Project
marcauberer abandoned D159402: [ValueTracking] Consider assumptions in isKnownNonEqual.
Sep 12 2023, 12:09 PM · Restricted Project, Restricted Project

Sep 9 2023

marcauberer updated marcauberer.
Sep 9 2023, 9:04 AM
marcauberer updated marcauberer.
Sep 9 2023, 9:04 AM
marcauberer updated marcauberer.
Sep 9 2023, 9:04 AM
marcauberer added a comment to D159402: [ValueTracking] Consider assumptions in isKnownNonEqual.

@jdoerfert @goldstein.w.n ping

Sep 9 2023, 9:00 AM · Restricted Project, Restricted Project

Sep 8 2023

marcauberer added inline comments to D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.
Sep 8 2023, 3:13 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.

Use computeKnownBits instead of isKnownNonEqual

Sep 8 2023, 3:10 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159204: [InstCombine] Baseline tests for folding (A/-B)==(A/B) to (A/B)==0.

Use icmp eq instead of ne for precondition

Sep 8 2023, 2:50 PM · Restricted Project, Restricted Project

Sep 7 2023

marcauberer added a comment to D159380: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B.

Can someone land the baseline tests patch and this patch for me? I do not have commit access.

Sep 7 2023, 2:34 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159380: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B.

Remove unnecessary nullptr checks

Sep 7 2023, 1:45 PM · Restricted Project, Restricted Project
marcauberer added reviewers for D159380: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B: lebedev.ri, huihuiz, fhahn, majnemer.
Sep 7 2023, 12:32 PM · Restricted Project, Restricted Project
marcauberer added reviewers for D159379: [InstCombine] Baseline tests for folding ((A&B)^A)|((A&B)^B) to A^B: lebedev.ri, huihuiz, fhahn, majnemer.
Sep 7 2023, 12:32 PM · Restricted Project, Restricted Project
marcauberer added reviewers for D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0: goldstein.w.n, lebedev.ri, sebastian-ne, greened.
Sep 7 2023, 12:27 PM · Restricted Project, Restricted Project
marcauberer added reviewers for D159204: [InstCombine] Baseline tests for folding (A/-B)==(A/B) to (A/B)==0: goldstein.w.n, lebedev.ri, sebastian-ne, greened.
Sep 7 2023, 12:27 PM · Restricted Project, Restricted Project

Sep 5 2023

marcauberer updated the diff for D159402: [ValueTracking] Consider assumptions in isKnownNonEqual.

Add tests and change order of checks

Sep 5 2023, 1:57 PM · Restricted Project, Restricted Project

Sep 2 2023

marcauberer added inline comments to D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.
Sep 2 2023, 5:23 AM · Restricted Project, Restricted Project
marcauberer updated the diff for D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.

Rebase onto ValueTracking change

Sep 2 2023, 5:19 AM · Restricted Project, Restricted Project
marcauberer requested review of D159402: [ValueTracking] Consider assumptions in isKnownNonEqual.
Sep 2 2023, 5:14 AM · Restricted Project, Restricted Project
marcauberer updated the diff for D159380: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B.

Reflect changes to tests

Sep 2 2023, 2:09 AM · Restricted Project, Restricted Project
marcauberer updated the diff for D159379: [InstCombine] Baseline tests for folding ((A&B)^A)|((A&B)^B) to A^B.

Address review comment

Sep 2 2023, 12:43 AM · Restricted Project, Restricted Project

Sep 1 2023

marcauberer updated the diff for D159380: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B.

Use lambda to avoid code duplication

Sep 1 2023, 2:19 PM · Restricted Project, Restricted Project
marcauberer updated the summary of D159380: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B.
Sep 1 2023, 2:18 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.

Rebase

Sep 1 2023, 1:27 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159204: [InstCombine] Baseline tests for folding (A/-B)==(A/B) to (A/B)==0.

Rebase

Sep 1 2023, 1:25 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159379: [InstCombine] Baseline tests for folding ((A&B)^A)|((A&B)^B) to A^B.

Update commit message

Sep 1 2023, 1:22 PM · Restricted Project, Restricted Project
marcauberer added reviewers for D159380: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B: GabrielRavier, RKSimon.
Sep 1 2023, 1:20 PM · Restricted Project, Restricted Project
marcauberer requested review of D159380: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B.
Sep 1 2023, 1:19 PM · Restricted Project, Restricted Project
marcauberer requested review of D159379: [InstCombine] Baseline tests for folding ((A&B)^A)|((A&B)^B) to A^B.
Sep 1 2023, 1:16 PM · Restricted Project, Restricted Project
marcauberer abandoned D159371: [InstCombine] Baseline tests for folding ((A&B)^A)|((A&B)^B) to A^B.
Sep 1 2023, 1:02 PM · Restricted Project, Restricted Project
marcauberer abandoned D159372: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B.
Sep 1 2023, 1:02 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159371: [InstCombine] Baseline tests for folding ((A&B)^A)|((A&B)^B) to A^B.

Rebase

Sep 1 2023, 12:57 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159371: [InstCombine] Baseline tests for folding ((A&B)^A)|((A&B)^B) to A^B.

Rebase

Sep 1 2023, 12:56 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159372: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B.

Rebase

Sep 1 2023, 12:52 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159372: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B.

Rebase

Sep 1 2023, 12:48 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159371: [InstCombine] Baseline tests for folding ((A&B)^A)|((A&B)^B) to A^B.

Update commit messgae

Sep 1 2023, 12:43 PM · Restricted Project, Restricted Project
marcauberer requested review of D159372: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B.
Sep 1 2023, 12:40 PM · Restricted Project, Restricted Project
marcauberer requested review of D159371: [InstCombine] Baseline tests for folding ((A&B)^A)|((A&B)^B) to A^B.
Sep 1 2023, 12:37 PM · Restricted Project, Restricted Project

Aug 30 2023

marcauberer added inline comments to D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.
Aug 30 2023, 2:41 PM · Restricted Project, Restricted Project
marcauberer added inline comments to D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.
Aug 30 2023, 12:48 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.

Apply review feedback

Aug 30 2023, 12:48 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.

Rebase

Aug 30 2023, 7:34 AM · Restricted Project, Restricted Project
marcauberer updated the diff for D159204: [InstCombine] Baseline tests for folding (A/-B)==(A/B) to (A/B)==0.

Rebased

Aug 30 2023, 7:33 AM · Restricted Project, Restricted Project
marcauberer updated the summary of D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.
Aug 30 2023, 7:14 AM · Restricted Project, Restricted Project
marcauberer updated the summary of D159204: [InstCombine] Baseline tests for folding (A/-B)==(A/B) to (A/B)==0.
Aug 30 2023, 7:14 AM · Restricted Project, Restricted Project
marcauberer updated the diff for D159204: [InstCombine] Baseline tests for folding (A/-B)==(A/B) to (A/B)==0.

Update link to code rev

Aug 30 2023, 7:13 AM · Restricted Project, Restricted Project
marcauberer requested review of D159204: [InstCombine] Baseline tests for folding (A/-B)==(A/B) to (A/B)==0.
Aug 30 2023, 7:10 AM · Restricted Project, Restricted Project
marcauberer requested review of D159203: [InstCombine] Fold (A/-B)==(A/B) to (A/B)==0.
Aug 30 2023, 7:09 AM · Restricted Project, Restricted Project

May 21 2023

marcauberer abandoned D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.
May 21 2023, 1:37 PM · Restricted Project, Restricted Project
marcauberer abandoned D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.
May 21 2023, 1:37 PM · Restricted Project, Restricted Project

Nov 23 2022

marcauberer added a comment to D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.

Some of the negative tests still evaluate to 'false' or 'true'. I currently have no idea how to fix this ...

Nov 23 2022, 12:55 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.

Rebase

Nov 23 2022, 12:53 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.

Apply improvements

Nov 23 2022, 12:47 PM · Restricted Project, Restricted Project

Nov 22 2022

marcauberer added inline comments to D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.
Nov 22 2022, 9:39 AM · Restricted Project, Restricted Project
marcauberer updated the diff for D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.

Apply latest baseline test changes

Nov 22 2022, 9:35 AM · Restricted Project, Restricted Project
marcauberer updated the diff for D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.

Test the right things:

Nov 22 2022, 9:24 AM · Restricted Project, Restricted Project

Oct 28 2022

marcauberer added inline comments to D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.
Oct 28 2022, 12:27 PM · Restricted Project, Restricted Project

Oct 27 2022

marcauberer added inline comments to D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.
Oct 27 2022, 1:13 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.

Rebase

Oct 27 2022, 1:02 PM · Restricted Project, Restricted Project
marcauberer added a comment to D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.

@spatel here we go! Everything should be tested now. Let me know if I am missing something.

Oct 27 2022, 12:54 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.

Add more tests for ValueTracking API calls

Oct 27 2022, 12:53 PM · Restricted Project, Restricted Project

Oct 24 2022

marcauberer added a comment to D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.

@spatel is one test case for icmpeq and one for icmpne enough for checking this?

Oct 24 2022, 12:12 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.

Add test cases for checking non-immediate select arms

Oct 24 2022, 12:11 PM · Restricted Project, Restricted Project

Oct 3 2022

marcauberer updated the diff for D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.

Fix 0 select arm tests

Oct 3 2022, 3:02 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.

Fix bug

Oct 3 2022, 2:55 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.

Rebase

Oct 3 2022, 2:11 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.

Rebase and format

Oct 3 2022, 1:51 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.

Fix naming

Oct 3 2022, 1:42 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.

Remove multi-use tests

Oct 3 2022, 1:37 PM · Restricted Project, Restricted Project
marcauberer added inline comments to D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.
Oct 3 2022, 1:17 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.

Delete superflous commuted tests and reflect changes from eq to the ne test file

Oct 3 2022, 1:14 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.

Add negative tests

Oct 3 2022, 1:09 PM · Restricted Project, Restricted Project

Sep 19 2022

marcauberer added a comment to D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.

As of tomorrow I am on vacation for about two weeks. I hope we can put this on hold until I am available again ...

Sep 19 2022, 11:30 AM · Restricted Project, Restricted Project
marcauberer updated the diff for D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.

Code improvements

Sep 19 2022, 11:27 AM · Restricted Project, Restricted Project

Sep 18 2022

marcauberer added a comment to rG09cdddea0c4d: [InstCombine] Fold x + (x | -x) to x & (x - 1).
In rG09cdddea0c4d284c2c22f5dfade40a60850c5ea7#1126088, @xbolva00 wrote:
In rG09cdddea0c4d284c2c22f5dfade40a60850c5ea7#1126083, @marcauberer wrote:

@nlopes Oh, thanks for reporting. Seems there is a copy/paste mistake in the code. Fixed it here: https://reviews.llvm.org/D134135

Upload fixed patch here - see button "Update Diff"

Sep 18 2022, 9:01 AM · Restricted Project, Restricted Project
marcauberer added a comment to rG09cdddea0c4d: [InstCombine] Fold x + (x | -x) to x & (x - 1).

@nlopes Oh, thanks for reporting. Seems there is a copy/paste mistake in the code. Fixed it here: https://reviews.llvm.org/D134135

Sep 18 2022, 7:27 AM · Restricted Project, Restricted Project
marcauberer requested review of D134135: [InstCombine] Fix bug when folding x + (x | -x) to x & (x - 1).
Sep 18 2022, 7:25 AM · Restricted Project, Restricted Project

Sep 16 2022

marcauberer added inline comments to D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.
Sep 16 2022, 4:49 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.

Add negative tests

Sep 16 2022, 4:46 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.

Consider more checks and icmp ne as well

Sep 16 2022, 4:41 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.

Rebase

Sep 16 2022, 12:49 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.

Rebase

Sep 16 2022, 12:48 PM · Restricted Project, Restricted Project
marcauberer abandoned D133855: [InstCombine] Baseline tests for folding ((x?1:4)&(y?1:4))==0 to x^y.
Sep 16 2022, 12:36 PM · Restricted Project, Restricted Project
marcauberer requested review of D134064: [InstCombine] Baseline tests for folding and-of-selects to xor.
Sep 16 2022, 12:31 PM · Restricted Project, Restricted Project

Sep 15 2022

marcauberer added a comment to D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.

Will execute clang-format later

Sep 15 2022, 12:47 AM · Restricted Project, Restricted Project
marcauberer updated the summary of D133855: [InstCombine] Baseline tests for folding ((x?1:4)&(y?1:4))==0 to x^y.
Sep 15 2022, 12:42 AM · Restricted Project, Restricted Project
marcauberer updated the diff for D133855: [InstCombine] Baseline tests for folding ((x?1:4)&(y?1:4))==0 to x^y.

Update summary

Sep 15 2022, 12:41 AM · Restricted Project, Restricted Project
marcauberer requested review of D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.
Sep 15 2022, 12:39 AM · Restricted Project, Restricted Project

Sep 14 2022

marcauberer requested review of D133855: [InstCombine] Baseline tests for folding ((x?1:4)&(y?1:4))==0 to x^y.
Sep 14 2022, 5:48 AM · Restricted Project, Restricted Project

Sep 9 2022

marcauberer added a comment to D133362: [InstCombine] Fold x + (x | -x) to x & (x - 1).

@spatel sorry, forgot to refresh the test ref. Now the change is ready for the final review ...

Sep 9 2022, 2:34 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D133362: [InstCombine] Fold x + (x | -x) to x & (x - 1).

Update test ref

Sep 9 2022, 2:33 PM · Restricted Project, Restricted Project
marcauberer added inline comments to D133362: [InstCombine] Fold x + (x | -x) to x & (x - 1).
Sep 9 2022, 12:49 PM · Restricted Project, Restricted Project
marcauberer updated the diff for D133362: [InstCombine] Fold x + (x | -x) to x & (x - 1).

Code cleanup

Sep 9 2022, 12:48 PM · Restricted Project, Restricted Project
marcauberer added inline comments to D133362: [InstCombine] Fold x + (x | -x) to x & (x - 1).
Sep 9 2022, 11:31 AM · Restricted Project, Restricted Project
marcauberer updated the diff for D133362: [InstCombine] Fold x + (x | -x) to x & (x - 1).

Code cleanup

Sep 9 2022, 11:28 AM · Restricted Project, Restricted Project
marcauberer updated the diff for D133362: [InstCombine] Fold x + (x | -x) to x & (x - 1).

Better handling for nuw and nsw flags in tests

Sep 9 2022, 11:20 AM · Restricted Project, Restricted Project