This is an archive of the discontinued LLVM Phabricator instance.

[llvm-lib] Ignore /SUBSYSTEM flag
ClosedPublic

Authored by pzheng on Jun 23 2022, 12:46 PM.

Details

Summary

It's not clear what Microsoft's LIB.exe actually does based on the official
description of the flag (link below). We can probably ignore it for now.

https://docs.microsoft.com/en-us/cpp/build/reference/managing-a-library?view=msvc-170

Diff Detail

Event Timeline

pzheng created this revision.Jun 23 2022, 12:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 23 2022, 12:46 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
pzheng requested review of this revision.Jun 23 2022, 12:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 23 2022, 12:46 PM
thieta accepted this revision.Jun 28 2022, 12:23 AM

LGTM.

This revision is now accepted and ready to land.Jun 28 2022, 12:23 AM
This revision was landed with ongoing or failed builds.Jun 28 2022, 9:47 AM
This revision was automatically updated to reflect the committed changes.