Page MenuHomePhabricator

[Flang] Call the CSE pass in the pass pipeline
ClosedPublic

Authored by kiranchandramohan on Wed, Jun 22, 11:18 AM.

Details

Summary

During the upstreaming process, it was decided to move contents
of the FIR CSE pass to the MLIR pass. Most of the FIR CSE changes
that are used are already moved to the MLIR pass. This patch calls
the MLIR CSE pass in places where the FIR CSE pass is called in the
pass pipeline.

Note: This is part of upstreaming from the fir-dev branch of
https://github.com/flang-compiler/f18-llvm-project.

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Co-authored-by: Valentin Clement <clementval@gmail.com>
Co-authored-by: Andrzej Warzynski <andrzej.warzynski@arm.com>

Diff Detail

Event Timeline

Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
kiranchandramohan requested review of this revision.Wed, Jun 22, 11:18 AM
This revision is now accepted and ready to land.Thu, Jun 23, 1:50 AM

Thanks Kiran! I'm a bit surprised that basic-program.fir doesn't require updating 🤔 . Can you take a look?

Thanks Kiran! I'm a bit surprised that basic-program.fir doesn't require updating 🤔 . Can you take a look?

This is because they are not strict checks like test_errors.py or the implicit-check-not option for FileCheck. Currently, it checks only for the presence of what is in the check line. I think we cannot make it stricter since mlir-pass-statistics dumps out some statistics in between.

This is because they are not strict checks like test_errors.py or the implicit-check-not option for FileCheck. Currently, it checks only for the presence of what is in the check line. I think we cannot make it stricter since mlir-pass-statistics dumps out some statistics in between.

Ah, ok, but the output in that file will also change and it would be good to update it too.

Update basic-program.fir test to address review comments.

This is because they are not strict checks like test_errors.py or the implicit-check-not option for FileCheck. Currently, it checks only for the presence of what is in the check line. I think we cannot make it stricter since mlir-pass-statistics dumps out some statistics in between.

Ah, ok, but the output in that file will also change and it would be good to update it too.

Done.

awarzynski accepted this revision.Thu, Jun 23, 3:14 AM

Thanks!

This revision was automatically updated to reflect the committed changes.