AMDGPU: Don't crash on global_ctor/dtor declaration

[foad]

llvm/lib/Target/AMDGPU/AMDGPUCtorDtorLowering.cpp

56

Don't need the !GA check here any more.

Alternatively you could use dyn_cast_or_null on line 55.

[nhaehnle]

llvm/lib/Target/AMDGPU/AMDGPUCtorDtorLowering.cpp

56

Isn't this just being defensive about what type the initializer is? That seems wise to me, you also wouldn't need a dyn_cast otherwise.

[foad]

llvm/lib/Target/AMDGPU/AMDGPUCtorDtorLowering.cpp

56

You're right, please ignore all my comments :(

[arsenm]

llvm/test/CodeGen/AMDGPU/lower-ctor-dtor-declaration.ll

2

Don't need -filetype=asm. Also don't need -o - if you're doing redirected input

[ruiling]

address review comments

llvm/lib/Target/AMDGPU/AMDGPUCtorDtorLowering.cpp

Function *createInitOrFiniKernelFunction(Module &M, bool IsCtor) {
     if (IsCtor)
       InitOrFiniKernel->addFnAttr("device-init");
     else
       InitOrFiniKernel->addFnAttr("device-fini");
     return InitOrFiniKernel;
   }
 
   bool createInitOrFiniKernel(Module &M, GlobalVariable *GV, bool IsCtor) {
-    if (!GV)
+    if (!GV || !GV->hasInitializer())
       return false;
     ConstantArray *GA = dyn_cast<ConstantArray>(GV->getInitializer());
     if (!GA || GA->getNumOperands() == 0)
       return false;
     Function *InitOrFiniKernel = createInitOrFiniKernelFunction(M, IsCtor);
     IRBuilder<> IRB(InitOrFiniKernel->getEntryBlock().getTerminator());
     for (Value *V : GA->operands()) {
       auto *CS = cast<ConstantStruct>(V);
       if (Function *F = dyn_cast<Function>(CS->getOperand(1))) {
         FunctionCallee Ctor =
             M.getOrInsertFunction(F->getName(), IRB.getVoidTy());

llvm/test/CodeGen/AMDGPU/lower-ctor-dtor-declaration.ll

+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx700 < %s | FileCheck %s
+
[e-mail]_ctors = external global [2 x { i32, void ()*, i8* }]
[e-mail]_dtors = external global [2 x { i32, void ()*, i8* }]
+
+; No amdgpu_kernels emitted for global_ctors declaration
+; CHECK-NOT: amdgcn.device.init
+; CHECK-NOT: amdgcn.device.fini