[mlir][vulkan-runner] fix VK_ERROR_INCOMPATIBLE_DRIVER error

[jackalcooper]

Summary

On macOS, Vulkan is emulated by MoltenVK. Some extra flags are required for "building robust and portable Vulkan based applications that are good citizens in the Vulkan ecosystem". More information: https://vulkan.lunarg.com/doc/sdk/1.3.216.0/mac/getting_started.html

[jackalcooper]

hi @antiagainst , I don't have commit access. Could you please commit the change?

[antiagainst]

In D128173#3600731, @jackalcooper wrote:

hi @antiagainst , I don't have commit access. Could you please commit the change?

Sure thing. What Git commit author information you'd like to use?

[jackalcooper]

In D128173#3601736, @antiagainst wrote:

In D128173#3600731, @jackalcooper wrote:

hi @antiagainst , I don't have commit access. Could you please commit the change?

Sure thing. What Git commit author information you'd like to use?

user.email [e-mail]
user.name jackalcooper

mlir/tools/mlir-vulkan-runner/VulkanRuntime.cpp

LogicalResult VulkanRuntime::createInstance() {
   applicationInfo.applicationVersion = 0;
   applicationInfo.pEngineName = "mlir";
   applicationInfo.engineVersion = 0;
   applicationInfo.apiVersion = VK_MAKE_VERSION(1, 0, 0);
 
   VkInstanceCreateInfo instanceCreateInfo = {};
   instanceCreateInfo.sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO;
   instanceCreateInfo.pNext = nullptr;
-  instanceCreateInfo.flags = 0;
   instanceCreateInfo.pApplicationInfo = &applicationInfo;
   instanceCreateInfo.enabledLayerCount = 0;
   instanceCreateInfo.ppEnabledLayerNames = nullptr;
-  instanceCreateInfo.enabledExtensionCount = 0;
-  instanceCreateInfo.ppEnabledExtensionNames = nullptr;
+
+  std::vector<const char *> extNames;
+#if defined(__APPLE__)
+  // enumerate MoltenVK for Vulkan 1.0
+  instanceCreateInfo.flags = VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR;
+  // add KHR portability instance extensions
+  extNames.push_back(VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);
+  extNames.push_back(VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME);
+#else
+  instanceCreateInfo.flags = 0;
+#endif // __APPLE__
+  instanceCreateInfo.enabledExtensionCount =
+      static_cast<uint32_t>(extNames.size());
+  instanceCreateInfo.ppEnabledExtensionNames = extNames.data();
 
   RETURN_ON_VULKAN_ERROR(
       vkCreateInstance(&instanceCreateInfo, nullptr, &instance),
       "vkCreateInstance");
   return success();
 }
 
 LogicalResult VulkanRuntime::createDevice() {