This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Assert initial load/store SEW is the EEW
ClosedPublic

Authored by reames on Jun 17 2022, 11:52 AM.

Details

Summary

In D127983, I had flipped from using the computed EEW to using the SEW value pulled from the VSETVLI when checking compatibility. This wasn't intentional, though thankfully it appears to be a non-functional difference. The new code does make a unchecked assumption that the initial SEW operand on the load/store is the EEW. This patch clarifies the assumption, and adds an assert to make sure this remains true.

Diff Detail

Event Timeline

reames created this revision.Jun 17 2022, 11:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2022, 11:52 AM
reames requested review of this revision.Jun 17 2022, 11:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2022, 11:52 AM
reames updated this revision to Diff 437999.Jun 17 2022, 11:56 AM

Wrap code in macro to avoid release build warning.

This revision is now accepted and ready to land.Jun 18 2022, 11:28 AM
This revision was landed with ongoing or failed builds.Jun 20 2022, 7:45 AM
This revision was automatically updated to reflect the committed changes.