This is an archive of the discontinued LLVM Phabricator instance.

[MachineCopyPropagation] Fix D125335 accidentally change control flow.
ClosedPublic

Authored by HanKuanChen on Jun 17 2022, 2:34 AM.

Diff Detail

Event Timeline

HanKuanChen created this revision.Jun 17 2022, 2:34 AM
HanKuanChen requested review of this revision.Jun 17 2022, 2:34 AM

Add tag and more information in commit message.

Update test.

adriantong1024 added inline comments.Jun 17 2022, 7:16 AM
llvm/lib/CodeGen/MachineCopyPropagation.cpp
663–686

Is this not the same as what is here already ?

933–935

Same here. Is this not the same as what is here already ?

HanKuanChen added inline comments.Jun 17 2022, 8:42 AM
llvm/lib/CodeGen/MachineCopyPropagation.cpp
663–686

No. The line 658 and 736 are included by the same loop (line 655).

933–935

Same. The line 929 and 949 are included by the same loop (line 926).

This revision is now accepted and ready to land.Jun 17 2022, 1:29 PM
craig.topper retitled this revision from Fix D125335 accidentally change control flow. to [MachineCopyPropagation] Fix D125335 accidentally change control flow..Jun 17 2022, 2:07 PM