This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] gfx11 new dot instruction codegen support
ClosedPublic

Authored by Joe_Nash on Jun 15 2022, 1:40 PM.

Diff Detail

Event Timeline

Joe_Nash created this revision.Jun 15 2022, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2022, 1:40 PM
Joe_Nash requested review of this revision.Jun 15 2022, 1:40 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 15 2022, 1:40 PM
Joe_Nash added reviewers: Restricted Project, Petar.Avramovic, arsen.Jun 15 2022, 1:41 PM
arsenm added inline comments.Jun 15 2022, 1:43 PM
llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.fdot2.f16.f16.ll
2 ↗(On Diff #437325)

Is there actually a reason to split the globalisel and DAG tests? I expect tests this simple to be identical

rampitec added inline comments.Jun 15 2022, 1:49 PM
clang/test/CodeGenOpenCL/builtins-amdgcn-dl-insts-err.cl
1

Also need positive tests like in builtins-amdgcn-dl-insts.cl.

llvm/include/llvm/IR/IntrinsicsAMDGPU.td
1957

I do not see clamp in the definition. Make a separate comment for the last 2?

Joe_Nash updated this revision to Diff 437552.Jun 16 2022, 8:28 AM
Joe_Nash marked 3 inline comments as done.

added builtin positive tests, removed clamp from intrinsic comments, combined gisel with normal codegen test

Joe_Nash added inline comments.Jun 16 2022, 9:56 AM
llvm/include/llvm/IR/IntrinsicsAMDGPU.td
1957

I removed clamp from the comments.

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.fdot2.f16.f16.ll
2 ↗(On Diff #437325)

Ok, I have combined the tests and they are identical.

This revision is now accepted and ready to land.Jun 16 2022, 10:43 AM
This revision was landed with ongoing or failed builds.Jun 16 2022, 11:49 AM
This revision was automatically updated to reflect the committed changes.