This is an archive of the discontinued LLVM Phabricator instance.

[X86][NFC] Use mnemonic tables in validateInstruction 4/4
ClosedPublic

Authored by Amir on Jun 13 2022, 11:48 PM.

Details

Summary

Group switch cases by opcode:

  • VGATHERDPD
  • VGATHERDPS
  • VGATHERQPD
  • VGATHERQPS
  • VPGATHERDD
  • VPGATHERDQ
  • VPGATHERQD
  • VPGATHERQQ

Distinguish masked vs non-masked forms by EVEX encoding.

Diff Detail

Event Timeline

Amir created this revision.Jun 13 2022, 11:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 11:48 PM
Amir requested review of this revision.Jun 13 2022, 11:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 11:48 PM
craig.topper added inline comments.
llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
3843

Looking at the later uses, should this be uint64_t TSFlags = MII.get(Opcode).TSFlags;? It doesn't look like any other fields are used.

Amir updated this revision to Diff 436842.Jun 14 2022, 10:12 AM

TSFlags

Amir edited the summary of this revision. (Show Details)Jun 14 2022, 10:14 AM
Amir added reviewers: skan, craig.topper, pengfei.
Amir marked an inline comment as done.Jun 14 2022, 10:15 AM
Amir added inline comments.
llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
3843

Agree.

This revision is now accepted and ready to land.Jun 14 2022, 10:35 AM
Amir updated this revision to Diff 436883.Jun 14 2022, 12:14 PM
Amir marked an inline comment as done.

clang-format

skan accepted this revision.Jun 14 2022, 7:51 PM

LGTM

This revision was landed with ongoing or failed builds.Jun 14 2022, 7:53 PM
This revision was automatically updated to reflect the committed changes.