This is an archive of the discontinued LLVM Phabricator instance.

[flang][NFC] Add source location information to report unsupported complex types
ClosedPublic

Authored by clementval on Jun 13 2022, 5:07 AM.

Details

Summary

This patch is part of the upstreaming effort from fir-dev branch.

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>

Diff Detail

Event Timeline

clementval created this revision.Jun 13 2022, 5:07 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 13 2022, 5:07 AM
Herald added a subscriber: mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Jun 13 2022, 5:07 AM
This revision is now accepted and ready to land.Jun 13 2022, 7:08 AM
PeteSteinfeld requested changes to this revision.Jun 13 2022, 7:16 AM

All builds and tests correctly, but it would be better to use calls to TODO() to emit not yet implemented messages.

flang/lib/Optimizer/CodeGen/Target.cpp
112

I'd rather see a call to TODO() here.

141

Better to make this a call to TODO().

160

Same here.

186

Same here.

203

And here.

295

And here.

This revision now requires changes to proceed.Jun 13 2022, 7:16 AM

Switch to TODOs

PeteSteinfeld accepted this revision.Jun 13 2022, 10:17 AM

Thanks, Valentin!

This revision is now accepted and ready to land.Jun 13 2022, 10:17 AM