This is an archive of the discontinued LLVM Phabricator instance.

[mlir][py-bindings] Fix include issue introduced by D127352
ClosedPublic

Authored by agostini01 on Jun 10 2022, 11:56 AM.

Details

Summary

Using:

-DMLIR_ENABLE_BINDINGS_PYTHON=ON

Resulted in a failed build due to changes implemented by
https://reviews.llvm.org/D127352

This updates the include line

Diff Detail

Event Timeline

agostini01 created this revision.Jun 10 2022, 11:56 AM
agostini01 requested review of this revision.Jun 10 2022, 11:56 AM
Mogball accepted this revision.Jun 10 2022, 11:57 AM

thanks!

This revision is now accepted and ready to land.Jun 10 2022, 11:57 AM

Hi @Mogball , I do not have commit access to the repo. Would you land this patch for me?

yup. I was having issues with arc earlier when I tried. Let me try again.

yup. I was having issues with arc earlier when I tried. Let me try again.

Mehdi and I ran into https://github.com/phacility/arcanist/pull/272 when attempting arc land recently

(well I think it's same case, I just locally hacked it given it was trying to access null value for commit snd I just added a test for null somewhere along the way to avoid it ...)

This revision was automatically updated to reflect the committed changes.