Details
Details
- Reviewers
ldionne Mordante var-const - Group Reviewers
Restricted Project - Commits
- rG6f27eb6ece32: [libc++] Use the same implementation of invoke for C++03 and C++11
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
The price to pay is a decrease in legibility of the main implementation of std::__invoke, however the benefit is really worth it IMO, so I'm happy with this.
Can you please check whether we have tests that could be expanded in C++03 now? I seem to recall seeing tests for invoke that wouldn't go beyond 3 arguments in C++03 mode or something like that, and they could be updated. The same should apply to mem_fn and reference_wrapper.
Comment Actions
I remember the last time I tried to do this, it broke a bunch of things. I can't remember why -- but it did.
Shouldn't this change turn on more tests in C++03?
Comment Actions
Shouldn't this change turn on more tests in C++03?
Which ones? I couldn't find any when looking.