This patch switches the build compiler for AIX from ibm-clang to clang. ibm-clang++_r has -pthread by default, but clang for AIX doesn't, so -pthread had to be added to the test config. A bunch of tests now pass, so the XFAIL was removed. This patch also switch the build to use the visibility support available in clang-15 to control symbols exported by the shared library (AIX traditionally uses explicit export lists for this purpose).
Details
Details
- Reviewers
daltenty ldionne - Group Reviewers
Restricted Project Restricted Project Restricted Project - Commits
- rG1cf4113952ae: [libcxx][AIX] Switch build compiler to clang
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
This comment was removed by Jake-Egan.
libcxx/CMakeLists.txt | ||
---|---|---|
472 | Would setting this in our AIX CMake cache file be sufficient? That might be preferable to hardcoding part of the tool chain in each of the top-level CMake files. |
Comment Actions
LGTM, with minor nit
libcxx/include/__config | ||
---|---|---|
131–134 | nit: It's probably worth a comment to explain this: |
Would setting this in our AIX CMake cache file be sufficient? That might be preferable to hardcoding part of the tool chain in each of the top-level CMake files.