This is an archive of the discontinued LLVM Phabricator instance.

Differential D127269

Add llvm's Support lib to the psuedoCXX library
ClosedPublic

Authored by lanza on Jun 7 2022, 7:42 PM.

Details

Reviewers
hokein
smeenai
Commits
rGdd2f2909188b: Add llvm's Support lib to the psuedoCXX library
Summary

This is failing to find EnableABIBreakingCheck at link time. Add
Support to provide it here.

Diff Detail

Event Timeline

lanza created this revision.Jun 7 2022, 7:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2022, 7:42 PM
Herald added a subscriber: mgorny. · View Herald Transcript
lanza requested review of this revision.Jun 7 2022, 7:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2022, 7:42 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
lanza added a reviewer: hokein.Jun 7 2022, 7:43 PM
Harbormaster completed remote builds in B168466: Diff 435029.Jun 7 2022, 7:58 PM
lanza added a reviewer: smeenai.Jun 7 2022, 8:13 PM
hokein accepted this revision.Jun 8 2022, 12:40 AM

Thanks!

This revision is now accepted and ready to land.Jun 8 2022, 12:40 AM
Closed by commit rGdd2f2909188b: Add llvm's Support lib to the psuedoCXX library (authored by lanza). · Explain WhyJun 8 2022, 2:12 PM
This revision was automatically updated to reflect the committed changes.
lanza added a commit: rGdd2f2909188b: Add llvm's Support lib to the psuedoCXX library.
MaskRay mentioned this in D127093: [clang][pseudo] Add missing Support lib to cxx.Jun 8 2022, 6:55 PM
jmciver mentioned this in D127271: [pseudo] Fix link time undefined reference to llvm::EnableABIBreakingChecks.Jun 8 2022, 8:36 PM

Revision Contents

PathSize
clang-tools-extra/
pseudo/
lib/
cxx/
4 lines

Diff 435321

clang-tools-extra/pseudo/lib/cxx/CMakeLists.txt

set(LLVM_LINK_COMPONENTS
Support
)
add_clang_library(clangPseudoCXX add_clang_library(clangPseudoCXX
CXX.cpp CXX.cpp
DEPENDS DEPENDS
cxx_gen cxx_gen
LINK_LIBS LINK_LIBS
clangPseudoGrammar clangPseudoGrammar
) )