This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
clang-tools-extra/pseudo/lib/cxx/
-
pseudo/
-
lib/
-
cxx/
-
CMakeLists.txt

Differential D127271

[pseudo] Fix link time undefined reference to llvm::EnableABIBreakingChecks
ClosedPublic

Authored by jmciver on Jun 7 2022, 11:31 PM.

Download Raw Diff

Details

Reviewers

hokein
sammccall

Summary

When building in debug mode, ABI breaking assertion checks are enabled and
require linking against LLVMSupport.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jmciver created this revision.Jun 7 2022, 11:31 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2022, 11:31 PM

Herald added a subscriber: mgorny. · View Herald Transcript

Harbormaster completed remote builds in B168481: Diff 435052.Jun 7 2022, 11:46 PM

jmciver published this revision for review.Jun 7 2022, 11:56 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2022, 11:56 PM

Herald added subscribers: cfe-commits, alextsao1999. · View Herald Transcript

jmciver added reviewers: hokein, sammccall.Jun 8 2022, 2:41 PM

This patch is associated to: https://github.com/llvm/llvm-project/issues/55935

Thanks!

This revision is now accepted and ready to land.Jun 8 2022, 2:56 PM

Thanks @sammccall for taking the time to review!

Can you please commit on my behalf?

Name: John McIver
Email: john.mciver.iii@gmail.com

Obsoleted by D127269.

Revision Contents

Path

Size

clang-tools-extra/

pseudo/

lib/

cxx/

1 line

Diff 435052

clang-tools-extra/pseudo/lib/cxx/CMakeLists.txt

	add_clang_library(clangPseudoCXX			add_clang_library(clangPseudoCXX
	CXX.cpp			CXX.cpp

	DEPENDS			DEPENDS
	cxx_gen			cxx_gen

	LINK_LIBS			LINK_LIBS
	clangPseudoGrammar			clangPseudoGrammar
				LLVMSupport
	)			)