This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
clang-tools-extra/pseudo/lib/cxx/
-
pseudo/
-
lib/
-
cxx/
-
CMakeLists.txt

Differential D127093

[clang][pseudo] Add missing Support lib to cxx
ClosedPublic

Authored by DavidSpickett on Jun 6 2022, 3:01 AM.

Download Raw Diff

Details

Reviewers

sammccall
MaskRay

Summary

Without this the following build config fails.

cmake ../llvm-project/llvm -DCMAKE_BUILD_TYPE=Debug \
  -DLLVM_TARGETS_TO_BUILD=X86 -DBUILD_SHARED_LIBS=ON \
  -DLLVM_APPEND_VC_REV=OFF -DLLVM_ENABLE_PROJECTS="lldb;clang;clang-tools-extra" \
  -G Ninja

With:

ld.lld: error: undefined symbol: llvm::EnableABIBreakingChecks
>>> referenced by CXX.cpp
>>>               tools/clang/tools/extra/pseudo/lib/cxx/CMakeFiles/obj.clangPseudoCXX.dir/CXX.cpp.o:(llvm::VerifyEnableABIBreakingChecks)

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

DavidSpickett created this revision.Jun 6 2022, 3:01 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 3:01 AM

Herald added subscribers: jsji, pengfei, mgorny. · View Herald Transcript

DavidSpickett requested review of this revision.Jun 6 2022, 3:01 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 3:01 AM

Herald added subscribers: cfe-commits, alextsao1999. · View Herald Transcript

I'm basing this on what psuedo/lib/grammar does, so I'm not totally sure this is the place to fix it.

Herald added a subscriber: StephenFan. · View Herald TranscriptJun 6 2022, 3:03 AM

DBUILD_SHARED_LIBS being the key setting in the config that causes the issue.

Harbormaster completed remote builds in B168002: Diff 434413.Jun 6 2022, 3:27 AM

Thanks! Obsoleted by D127269

This revision is now accepted and ready to land.Jun 8 2022, 6:55 PM

MaskRay closed this revision.Jun 8 2022, 6:55 PM

Revision Contents

Path

Size

clang-tools-extra/

pseudo/

lib/

cxx/

CMakeLists.txt

2 lines

Diff 434413

clang-tools-extra/pseudo/lib/cxx/CMakeLists.txt

				set(LLVM_LINK_COMPONENTS Support)

	add_clang_library(clangPseudoCXX			add_clang_library(clangPseudoCXX
	CXX.cpp			CXX.cpp

	DEPENDS			DEPENDS
	cxx_gen			cxx_gen

	LINK_LIBS			LINK_LIBS
	clangPseudoGrammar			clangPseudoGrammar
	)			)