This is an archive of the discontinued LLVM Phabricator instance.

[LoongArch] Add codegen support for fneg
ClosedPublic

Authored by SixWeining on Jun 7 2022, 4:35 AM.

Diff Detail

Event Timeline

SixWeining created this revision.Jun 7 2022, 4:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2022, 4:35 AM
SixWeining requested review of this revision.Jun 7 2022, 4:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2022, 4:35 AM
rengolin accepted this revision.Jun 7 2022, 5:31 AM

LGTM, simple and straightforward.

This revision is now accepted and ready to land.Jun 7 2022, 5:31 AM
xen0n accepted this revision.Jun 8 2022, 11:04 PM

This is just one fneg so you may change the title to just "[LoongArch] Add codegen support for fneg" instead.

Otherwise it looks good!

SixWeining retitled this revision from [LoongArch 2/n] Add codegen support for the unary operation to [LoongArch] Add codegen support for fneg.Jun 9 2022, 2:03 AM
SixWeining edited the summary of this revision. (Show Details)

This is just one fneg so you may change the title to just "[LoongArch] Add codegen support for fneg" instead.

Otherwise it looks good!

Thanks. I just updated the title.

SixWeining updated this revision to Diff 435761.Jun 9 2022, 6:58 PM

Remove the patch number in the title. (I already remove it in Phabricator yesterday.)

xen0n accepted this revision.Jun 9 2022, 7:43 PM
MaskRay accepted this revision.Jun 10 2022, 8:12 PM
MaskRay added inline comments.
llvm/test/CodeGen/LoongArch/ir-instruction/fneg.ll
1

Consider placing some arithmetic tests in one file, instead of one file for each instruction.
This may run llc too many times, slowing down testsuite execution.

4

For some test directories, we use ;; to emphasize non-RUN non-CHECK lines.
This may help update_*_checks.py tools or improve FileCheck to detect some error-prone usage.

Address @MaskRay's comment: use ;; to emphasize non-RUN non-CHECK lines.

MaskRay accepted this revision.Jun 12 2022, 1:00 AM

adjust the dependency

MaskRay accepted this revision.Jun 13 2022, 4:49 PM
xen0n accepted this revision.Jun 15 2022, 11:36 PM

still LGTM after rebase

This revision was landed with ongoing or failed builds.Jun 19 2022, 6:54 PM
This revision was automatically updated to reflect the committed changes.