This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Support 'G' in .eh_frame
ClosedPublic

Authored by fmayer on Jun 6 2022, 1:40 PM.

Diff Detail

Event Timeline

fmayer created this revision.Jun 6 2022, 1:40 PM
Herald added a project: Restricted Project. · View Herald Transcript
fmayer requested review of this revision.Jun 6 2022, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 1:40 PM
eugenis accepted this revision.Jun 6 2022, 5:31 PM

LGTM

This revision is now accepted and ready to land.Jun 6 2022, 5:31 PM
fmayer updated this revision to Diff 434654.Jun 6 2022, 5:42 PM

test more

MaskRay added a comment.EditedJun 6 2022, 5:49 PM

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp code can be tested with llvm-objdump/llvm-dwarfdump but should have a test in test/DebugInfo.

lld doesn't use llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp code. It's inappropriate to rely on lld/test/ELF to provide the test coverage.

You should move llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp into another patch with a test/DebugInfo patch.

fmayer updated this revision to Diff 434663.Jun 6 2022, 6:03 PM

remove DWARF parser

fmayer updated this revision to Diff 434664.Jun 6 2022, 6:04 PM

remove dwarf test

fmayer retitled this revision from [ELF] Support 'G' in lld and dwarf parser to [ELF] Support 'G' in lld.Jun 6 2022, 6:04 PM

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp code can be tested with llvm-objdump/llvm-dwarfdump but should have a test in test/DebugInfo.

lld doesn't use llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp code. It's inappropriate to rely on lld/test/ELF to provide the test coverage.

You should move llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp into another patch with a test/DebugInfo patch.

Done, moved DWARF change to D127171.

MaskRay accepted this revision.Jun 6 2022, 7:31 PM
MaskRay added inline comments.
lld/test/ELF/stack-tagging-cfi.s
1
3

-s is not needed

20

Delete NoUnwind

fmayer marked 3 inline comments as done.Jun 7 2022, 1:18 PM
fmayer updated this revision to Diff 434927.Jun 7 2022, 1:21 PM

address comments

fmayer updated this revision to Diff 434931.Jun 7 2022, 1:26 PM

address comment

fmayer updated this revision to Diff 434943.Jun 7 2022, 1:58 PM

remove comments

MaskRay accepted this revision.Jun 7 2022, 2:29 PM
MaskRay retitled this revision from [ELF] Support 'G' in lld to [ELF] Support 'G' in .eh_frame.
This revision was automatically updated to reflect the committed changes.
fmayer reopened this revision.Jun 8 2022, 1:53 PM

Tests broke on windows.

This revision is now accepted and ready to land.Jun 8 2022, 1:53 PM
fmayer updated this revision to Diff 435332.Jun 8 2022, 2:25 PM

add requires aarch64

This revision was landed with ongoing or failed builds.Jun 8 2022, 2:29 PM
This revision was automatically updated to reflect the committed changes.