Details
- Reviewers
var-const Mordante ldionne jdoerfert - Group Reviewers
Restricted Project - Commits
- rGafd5a4f2dcd6: [libc++] Implement ranges::lexicographical_compare
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libcxx/include/__algorithm/ranges_lexicographical_compare.h | ||
---|---|---|
64 | Nit: add the include. | |
libcxx/test/std/algorithms/alg.sorting/alg.lex.comparison/ranges.lexicographical_compare.pass.cpp | ||
133 | Please also add tests with a non-default projection or a non-default comparator. | |
190 | Question: why is std::begin necessary here? |
libcxx/test/std/algorithms/alg.sorting/alg.lex.comparison/ranges.lexicographical_compare.pass.cpp | ||
---|---|---|
190 | It's not necessary, but I think std::begin and std::end should always go together. It is just another thing you have to think about otherwise. |
libcxx/test/std/algorithms/alg.sorting/alg.lex.comparison/ranges.lexicographical_compare.pass.cpp | ||
---|---|---|
190 | Sorry, what I meant was, why not just use (a, a + 5, a, a + 5, red, proj1, proj2)? |
Nit: add the include.