This patch removes CodeAlignmentFactor and DataAlignmentFactor validation in EHFrameEdgeFixer. I observed some of aarch64 elf files generated by clang contains CIE record with code_alignment_factor = 4 or data_alignment_factor = -8. If I'm understading correctly, code_alignment_factor and data_alignment_factor are used by call fram instruction that should be correctled handled by libunwind. But, I also see the verification was added in the intial code base and not touched since then.
Details
Details
Summary
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
sunho added a parent revision: D127061: [JITLink][ELF/AARCH64] Implement Procedure Linkage Table.Jun 4 2022, 6:13 PM
trukhaav added a parent revision: D126222: [libcxx] Fix wrong messages of git version.Jun 5 2022, 12:30 AM
sunho removed a parent revision: D126222: [libcxx] Fix wrong messages of git version.Jun 5 2022, 7:08 AM
This revision is now accepted and ready to land.Jun 9 2022, 3:19 PM
sunho removed a parent revision: D127061: [JITLink][ELF/AARCH64] Implement Procedure Linkage Table.Jun 9 2022, 11:21 PM
This revision was landed with ongoing or failed builds.Jun 9 2022, 11:29 PM
Closed by commit rG6d67f7a3294d: [JITLink][EHFrameSupport] Remove CodeAlignmentFactor and DataAlignmentFactor… (authored by sunho). · Explain Why
This revision was automatically updated to reflect the committed changes.
sunho removed a child revision: D127063: [JITLink][ELF/AARCH64] Implement eh frame handling .Jun 9 2022, 11:42 PM