Page MenuHomePhabricator

[JITLink] Remove CodeAlignmentFactor and DataAlignmentFactor validation
ClosedPublic

Authored by sunho on Jun 4 2022, 6:08 PM.

Details

Summary

This patch removes CodeAlignmentFactor and DataAlignmentFactor validation in EHFrameEdgeFixer. I observed some of aarch64 elf files generated by clang contains CIE record with code_alignment_factor = 4 or data_alignment_factor = -8. If I'm understading correctly, code_alignment_factor and data_alignment_factor are used by call fram instruction that should be correctled handled by libunwind. But, I also see the verification was added in the intial code base and not touched since then.

Diff Detail

Unit TestsFailed

TimeTest
1,230 msx64 debian > LeakSanitizer-AddressSanitizer-x86_64.TestCases::realloc_too_big.c
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -O0 -m64 -gline-tables-only -fsanitize=address -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/lsan/../ /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/lsan/TestCases/realloc_too_big.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/lsan/X86_64AsanConfig/TestCases/Output/realloc_too_big.c.tmp
1,200 msx64 debian > LeakSanitizer-Standalone-x86_64.TestCases::realloc_too_big.c
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -O0 -m64 -gline-tables-only -fsanitize=leak -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/lsan/../ /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/lsan/TestCases/realloc_too_big.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/lsan/X86_64LsanConfig/TestCases/Output/realloc_too_big.c.tmp

Event Timeline

sunho created this revision.Jun 4 2022, 6:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2022, 6:08 PM
sunho requested review of this revision.Jun 4 2022, 6:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2022, 6:08 PM
lhames accepted this revision.Jun 9 2022, 3:19 PM

LGTM. Thanks @sunho!

This revision is now accepted and ready to land.Jun 9 2022, 3:19 PM
This revision was landed with ongoing or failed builds.Jun 9 2022, 11:29 PM
This revision was automatically updated to reflect the committed changes.