This is an archive of the discontinued LLVM Phabricator instance.

[mlir][AMDGPU] Set ABI version constant when linking device libs
ClosedPublic

Authored by krzysz00 on Jun 2 2022, 1:23 PM.

Details

Summary

Currently, linking the device libraries requires setting a constant
that indicates the code object ABI version the compilation is
targeting.

This fixes the MLIR linking process by setting this constant to 400,
which is the value corresponding to the current code object ABI
default, version 4.

Diff Detail

Event Timeline

krzysz00 created this revision.Jun 2 2022, 1:23 PM
krzysz00 requested review of this revision.Jun 2 2022, 1:23 PM

We don't have tests for this stuff?

The only test I can think of that could catch this is an integration test, and our buildbot isn't testing against pre-release versions of the backend

Mogball accepted this revision.Jun 10 2022, 11:39 AM
This revision is now accepted and ready to land.Jun 10 2022, 11:39 AM