[analyzer] Remove NotifyAssumeClients

[martong]

Summary

Depends on D126560.

[steakhal]

Measure if it changes any reports.

[martong]

In D126878#3553184, @steakhal wrote:

Measure if it changes any reports.

Results did not change, we had equal number of reports in all projects. Other stat numbers are also very close.

stats.html208 KBDownload

[steakhal]

Great! Thanks.

clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h

public:
 
   virtual void printJson(raw_ostream &Out, ProgramStateRef State,
                          const char *NL, unsigned int Space,
                          bool IsDot) const = 0;
 
   /// Convenience method to query the state to see if a symbol is null or
   /// not null, or if neither assumption can be made.
   ConditionTruthVal isNull(ProgramStateRef State, SymbolRef Sym) {
-    SaveAndRestore<bool> DisableNotify(NotifyAssumeClients, false);
-
     return checkNull(State, Sym);
   }
 
 protected:
-  /// A flag to indicate that clients should be notified of assumptions.
-  /// By default this is the case, but sometimes this needs to be restricted
-  /// to avoid infinite recursions within the ConstraintManager.
-  ///
-  /// Note that this flag allows the ConstraintManager to be re-entrant,
-  /// but not thread-safe.
-  bool NotifyAssumeClients = true;
-
   /// A helper class to simulate the call stack of nested assume calls.
   class AssumeStackTy {
   public:
     void push(const ProgramState *S) { Aux.push_back(S); }
     void pop() { Aux.pop_back(); }
     bool contains(const ProgramState *S) const {
       return llvm::is_contained(Aux, S);
     }

clang/lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp

ProgramStateRef SimpleConstraintManager::assumeInternal(ProgramStateRef State,
   }
 
   return assume(State, Cond.castAs<NonLoc>(), Assumption);
 }
 
 ProgramStateRef SimpleConstraintManager::assume(ProgramStateRef State,
                                                 NonLoc Cond, bool Assumption) {
   State = assumeAux(State, Cond, Assumption);
-  if (NotifyAssumeClients && EE)
+  if (EE)
     return EE->processAssume(State, Cond, Assumption);
   return State;
 }
 
 ProgramStateRef SimpleConstraintManager::assumeAux(ProgramStateRef State,
                                                    NonLoc Cond,
                                                    bool Assumption) {