[flang] Add team_type to num_images intrinsic call

[ktras]

Summary

num_images had previously been added to the list of intrinsics
before the type team_type had been implemented. Now that team_type
is implemented, add the num_images call that has the team argument.
Update the semantics tests for num_images.

[craig.rasmussen]

flang/test/Semantics/num_images02.f90

24

It looks like this comment should go away.

[ktras]

• In the semantics test, remove section of comment that says "not yet supported" when referring to the team argument
• Fix the formatting in the changes in flang/lib/Evaluate/intrinsics.cpp after running git clang-format

flang/test/Semantics/num_images02.f90

24

Thank you for catching that! I have now removed the "not yet supported" part of that comment.

[craig.rasmussen]

Looks good to me.

[ktras]

I don't have push permissions, so if there is no more feedback on this differential, can someone push this to main for me please?

flang/lib/Evaluate/intrinsics.cpp

static const IntrinsicInterface genericIntrinsicFunction[]{
         Rank::scalar, IntrinsicClass::inquiryFunction},
     {"nint", {{"a", AnyReal}, DefaultingKIND}, KINDInt},
     {"norm2", {{"x", SameReal, Rank::array}, OptionalDIM}, SameReal,
         Rank::dimReduced, IntrinsicClass::transformationalFunction},
     {"not", {{"i", SameInt}}, SameInt},
     // NULL() is a special case handled in Probe() below
     {"num_images", {}, DefaultInt, Rank::scalar,
         IntrinsicClass::transformationalFunction},
+    {"num_images", {{"team", TeamType, Rank::scalar}}, DefaultInt,
+        Rank::scalar, IntrinsicClass::transformationalFunction},
     {"num_images", {{"team_number", AnyInt, Rank::scalar}}, DefaultInt,
         Rank::scalar, IntrinsicClass::transformationalFunction},
     {"out_of_range",
         {{"x", AnyIntOrReal}, {"mold", AnyIntOrReal, Rank::scalar}},
         DefaultLogical},
     {"out_of_range",
         {{"x", AnyReal}, {"mold", AnyInt, Rank::scalar},
             {"round", AnyLogical, Rank::scalar, Optionality::optional}},

flang/test/Semantics/num_images01.f90

 ! RUN: %python %S/test_errors.py %s %flang_fc1
 ! Check for semantic errors in num_images() function calls
 
 subroutine test
+  use iso_fortran_env, only: team_type
+  implicit none
+
+  type(team_type) my_team
 
   ! correct calls, should produce no errors
   print *, num_images()
   print *, num_images(team_number=1)
   print *, num_images(1)
+  print *, num_images(my_team)
+  print *, num_images(team=my_team)
 
   ! incorrectly typed argument
   ! the error is seen as too many arguments to the num_images() call with no arguments
   !ERROR: too many actual arguments for intrinsic 'num_images'
   print *, num_images(3.4)
 
   ! call with too many arguments
   !ERROR: too many actual arguments for intrinsic 'num_images'
   print *, num_images(1, 1)
 
   ! keyword argument with incorrect type
   !ERROR: unknown keyword argument to intrinsic 'num_images'
   print *, num_images(team_number=3.4)
 
   ! incorrect keyword argument
   !ERROR: unknown keyword argument to intrinsic 'num_images'
   print *, num_images(team_numbers=1)
 
-  !TODO: test num_images() calls related to team_type argument
+  !ERROR: unknown keyword argument to intrinsic 'num_images'
+  print *, num_images(teams=my_team)
 
 end subroutine

flang/test/Semantics/num_images02.f90

program num_images_with_team_type
 
   !___ standard-conforming statements with team_number argument present ___
   n = num_images(-1)
   n = num_images(team_number = -1)
   n = num_images(team_number = standard_initial_value)
   n = num_images(standard_initial_value)
   n = num_images(coindexed[1])
 
   !___ standard-conforming statements with team_type argument present (not yet supported) ___
 
-  !ERROR: too many actual arguments for intrinsic 'num_images'
   n = num_images(home)
-
-  !ERROR: unknown keyword argument to intrinsic 'num_images'
   n = num_images(team=home)
 
   !___ non-conforming statements ___
 
   ! non-scalar integer argument 
   !ERROR: unknown keyword argument to intrinsic 'num_images'
   n = num_images(team_number=array)