LGTM. @samdsilvaa, I don't believe you have push permissions, would you like me to push on your behalf?

LGTM. @ElliotWhitney, I don't believe you have push permissions, would you like me to push on your behalf?

Thanks for the review, @PeteSteinfeld. You have requested changes to this revision but from the text of your comment, it seems like you accidentally requested changes. If you did mean to request changes, please let me know what needs to be updated.

@PeteSteinfeld, thanks for letting me know. You are right that the event-variable in an event-post-stmt is allowed to be a coindexed-object. It seems like the using the function evaluate::IsCoarray, as I did, to make sure that event-variable is a coarray disallows coindexed-objects. I will make some changes and open a new differential to address this.

Thanks for the review, @PeteSteinfeld.

Unfortunately, I let this patch sitting for a while, but I would like to push this soon. @PeteSteinfeld, thank you for the review and for the acceptance of the patch. Previously, I replied to your comment about moving IsEventType and IsLockType and stating that because of future planned changes to support event_query, it seems to me that these new functions should remain where they are now in this patch. Please let me know if you disagree, otherwise I plan to push this differential within the next couple days based on the revision having been accepted. Let me know if you would like me to hold off for further discussion, thanks.

Thank you for making the requested changes.
LGTM.

Is there a test you could add to this patch to show that the changes work as expected?

Thanks @hussainjk for these tests. Per my comment inline of change_team01c.f90, the branching that is specified by the standard was not tested. However, locally I began to work on adding the ability for flang to check whether branching occurs or not in a change-team-construct, and while doing so I began to add to my local copy of your test to check my implementation. As I know that your focus is no longer on testing, if you update this patch and remove lines 11-24 from that test, then I can approve this patch. I will then add to your tests checks for branching in the patch that I submit to add additional checks on change-team-construct in flang.

@PeteSteinfeld Thanks for noticing that change that affected my patch! I have integrated the latest changes and updated the test accordingly.

Update test based on recent changes in flang.

@PeteSteinfeld Thanks for the review!

@rouson Thanks for the review. I have landed this patch and based on your suggestion, I will work on a separate test and separate differential where I will test the different possibilities for declarations of type lock_type and testing the constraints that you referenced.

@jeanPerier Thanks for the review!

@PeteSteinfeld Thanks for the review!

Ping.

Move comment location.

Make changes based on reviewer feedback: Add comments with numbered constraints and change an assignment statement to braced initialization.

I am abandoning this revision in favor of a new revision which a smaller section of these changes.

@rouson Thank you for the review, the recommended changes have been made.

Update function signature of new function, CheckAtomicKind, based on reviewer feedback.

Okay, sounds great. I will commit this on your behalf.

Do you have commit permissions? Or do you need someone to commit on your behalf?

• Add a check for a coindexed-object for the optional dummy argument 'stat', which "shall be a noncoindexed integer scalar".
• Updates based on reviewer feedback

Ping.

Update patch based on reviewer feedback:

I will updated my patch based on reviewer feedback on the implementation of one of the new errors and the implementation of the atomic_int_kind check.

@jeanPerier Thank you for the feedback! I think the idea to use flang/module/__fortran_builtins.f90 seems like a great idea and I will pursue that option. Thank you for pointing out how that could be useful in this case.