Page MenuHomePhabricator

ktras (Katherine Rasmussen)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 3 2020, 11:21 AM (116 w, 6 d)

Recent Activity

Yesterday

ktras committed rGaa1a2ffdbf60: [flang] Add atomic_fetch_or to the list of intrinsics (authored by ktras).
[flang] Add atomic_fetch_or to the list of intrinsics
Thu, Sep 29, 9:35 AM · Restricted Project, Restricted Project
ktras closed D133174: [flang] Add atomic_fetch_or to the list of intrinsics.
Thu, Sep 29, 9:35 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 28

ktras accepted D134205: Write semantics test for FORM-TEAM statement..

Do you have commit permissions? Or do you need someone to commit on your behalf?

Wed, Sep 28, 5:35 PM · Restricted Project, Restricted Project
ktras added inline comments to D133174: [flang] Add atomic_fetch_or to the list of intrinsics.
Wed, Sep 28, 10:43 AM · Restricted Project, Restricted Project, Restricted Project
ktras updated the diff for D133174: [flang] Add atomic_fetch_or to the list of intrinsics.
  • Add a check for a coindexed-object for the optional dummy argument 'stat', which "shall be a noncoindexed integer scalar".
  • Updates based on reviewer feedback
Wed, Sep 28, 10:40 AM · Restricted Project, Restricted Project, Restricted Project
ktras committed rGbc2a85f16c58: [flang] Add co_broadcast to the list of intrinsics (authored by ktras).
[flang] Add co_broadcast to the list of intrinsics
Wed, Sep 28, 9:34 AM · Restricted Project, Restricted Project
ktras closed D134786: [flang] Add co_broadcast to the list of intrinsics.
Wed, Sep 28, 9:34 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 27

ktras requested review of D134786: [flang] Add co_broadcast to the list of intrinsics.
Tue, Sep 27, 8:53 PM · Restricted Project, Restricted Project, Restricted Project
ktras committed rG0195d1323220: [flang] Add co_min and co_max to the list of intrinsics (authored by ktras).
[flang] Add co_min and co_max to the list of intrinsics
Tue, Sep 27, 4:15 PM · Restricted Project, Restricted Project
ktras closed D133526: [flang] Add co_min and co_max to the list of intrinsics.
Tue, Sep 27, 4:15 PM · Restricted Project, Restricted Project, Restricted Project
ktras added a comment to D133526: [flang] Add co_min and co_max to the list of intrinsics.

Ping.

Tue, Sep 27, 10:18 AM · Restricted Project, Restricted Project, Restricted Project
ktras updated the diff for D133174: [flang] Add atomic_fetch_or to the list of intrinsics.

Update patch based on reviewer feedback:

Tue, Sep 27, 12:09 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 26

ktras committed rGa64bce963d0b: [flang] Write semantics test for atomic_define (authored by ktras).
[flang] Write semantics test for atomic_define
Mon, Sep 26, 9:59 PM · Restricted Project, Restricted Project
ktras closed D134288: [flang] Write semantics test for atomic_define.
Mon, Sep 26, 9:59 PM · Restricted Project, Restricted Project, Restricted Project
ktras planned changes to D133174: [flang] Add atomic_fetch_or to the list of intrinsics.

I will updated my patch based on reviewer feedback on the implementation of one of the new errors and the implementation of the atomic_int_kind check.

Mon, Sep 26, 11:34 AM · Restricted Project, Restricted Project, Restricted Project
ktras added a comment to D133174: [flang] Add atomic_fetch_or to the list of intrinsics.

@jeanPerier Thank you for the feedback! I think the idea to use flang/module/__fortran_builtins.f90 seems like a great idea and I will pursue that option. Thank you for pointing out how that could be useful in this case.

Mon, Sep 26, 10:20 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 21

ktras committed rGadb2ba5ca3b6: [flang] Write semantics test for atomic_xor (authored by ktras).
[flang] Write semantics test for atomic_xor
Wed, Sep 21, 3:55 PM · Restricted Project, Restricted Project
ktras closed D134298: [flang] Write semantics test for atomic_xor.
Wed, Sep 21, 3:55 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 20

ktras updated the diff for D134288: [flang] Write semantics test for atomic_define.

Realized that I had multiple errors on the lines where I am trying to test a single error. Changed those calls so that they target one error.

Tue, Sep 20, 4:46 PM · Restricted Project, Restricted Project, Restricted Project
ktras added a comment to D134205: Write semantics test for FORM-TEAM statement..

The tests look great! Please see my inline comments for some suggestions. Also, I see that you are checking to make sure that type mismatches for the team-number, team-variable and the specifiers in the form-team-spec-list are caught, which is great. Since all of these are supposed to be scalar, what about checking that rank mismatches for team-number, team-variable and the specifiers are not allowed?

Tue, Sep 20, 4:29 PM · Restricted Project, Restricted Project
ktras committed rG9df4e00d4a11: [flang] Add semantics test for atomic_add subroutine (authored by ngeorge1098).
[flang] Add semantics test for atomic_add subroutine
Tue, Sep 20, 2:20 PM · Restricted Project, Restricted Project
ktras closed D131535: [flang] Add semantics test for atomic_add subroutine.
Tue, Sep 20, 2:20 PM · Restricted Project, Restricted Project, Restricted Project
ktras requested review of D134298: [flang] Write semantics test for atomic_xor.
Tue, Sep 20, 11:54 AM · Restricted Project, Restricted Project, Restricted Project
ktras committed rG2e58d3e33487: [flang] Write semantics test for atomic_or (authored by ktras).
[flang] Write semantics test for atomic_or
Tue, Sep 20, 11:21 AM · Restricted Project, Restricted Project
ktras closed D134200: [flang] Write semantics test for atomic_or.
Tue, Sep 20, 11:21 AM · Restricted Project, Restricted Project, Restricted Project
ktras requested review of D134288: [flang] Write semantics test for atomic_define.
Tue, Sep 20, 9:42 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 19

ktras added a reviewer for D133070: [flang] Add check for constraints on sync-stat-lists and other constraints in sync-images-stmt, and event statements: hussainjk.
Mon, Sep 19, 11:13 AM · Restricted Project, Restricted Project, Restricted Project
ktras requested review of D134200: [flang] Write semantics test for atomic_or.
Mon, Sep 19, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
ktras added a comment to D133526: [flang] Add co_min and co_max to the list of intrinsics.

Ping.

Mon, Sep 19, 9:16 AM · Restricted Project, Restricted Project, Restricted Project
ktras added a comment to D133727: [flang] Write semantics test for atomic_and.

Thanks for the feedback. Your suggestions have been done.

Mon, Sep 19, 8:57 AM · Restricted Project, Restricted Project, Restricted Project
ktras committed rGe13b273d63d2: [flang] Write semantics test for atomic_and (authored by ktras).
[flang] Write semantics test for atomic_and
Mon, Sep 19, 8:49 AM · Restricted Project, Restricted Project
ktras closed D133727: [flang] Write semantics test for atomic_and.
Mon, Sep 19, 8:48 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 13

ktras committed rG49f3f9767408: [flang] Write semantics test for atomic_fetch_xor (authored by ktras).
[flang] Write semantics test for atomic_fetch_xor
Tue, Sep 13, 5:20 PM · Restricted Project, Restricted Project
ktras closed D133704: [flang] Write semantics test for atomic_fetch_xor.
Tue, Sep 13, 5:20 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 12

ktras requested review of D133727: [flang] Write semantics test for atomic_and.
Mon, Sep 12, 2:40 PM · Restricted Project, Restricted Project, Restricted Project
ktras requested review of D133704: [flang] Write semantics test for atomic_fetch_xor.
Mon, Sep 12, 8:57 AM · Restricted Project, Restricted Project, Restricted Project
ktras committed rGe4ee56b4e043: [flang] Write semantics test for atomic_fetch_and (authored by ktras).
[flang] Write semantics test for atomic_fetch_and
Mon, Sep 12, 8:43 AM · Restricted Project, Restricted Project
ktras closed D133506: [flang] Write semantics test for atomic_fetch_and.
Mon, Sep 12, 8:42 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 8

ktras requested review of D133526: [flang] Add co_min and co_max to the list of intrinsics.
Thu, Sep 8, 2:08 PM · Restricted Project, Restricted Project, Restricted Project
ktras requested review of D133506: [flang] Write semantics test for atomic_fetch_and.
Thu, Sep 8, 10:35 AM · Restricted Project, Restricted Project, Restricted Project
ktras added a comment to D133070: [flang] Add check for constraints on sync-stat-lists and other constraints in sync-images-stmt, and event statements.

Ping.

Thu, Sep 8, 10:31 AM · Restricted Project, Restricted Project, Restricted Project
ktras committed rG2944f8ef049f: [flang] Add co_sum to the list of intrinsics and update test (authored by ktras).
[flang] Add co_sum to the list of intrinsics and update test
Thu, Sep 8, 9:40 AM · Restricted Project, Restricted Project
ktras closed D114134: [flang] Add co_sum to the list of intrinsics and update test.
Thu, Sep 8, 9:40 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 7

ktras committed rG95b78898504c: [flang] Write semantics test for atomic_fetch_add (authored by ktras).
[flang] Write semantics test for atomic_fetch_add
Wed, Sep 7, 5:50 PM · Restricted Project, Restricted Project
ktras closed D133139: [flang] Write semantics test for atomic_fetch_add.
Wed, Sep 7, 5:50 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 1

ktras added a comment to D133174: [flang] Add atomic_fetch_or to the list of intrinsics.

In this patch, in flang/lib/Evaluate/intrinsics.cpp, I would like to be able to bring in and use the value atomic_int_kind from the iso_fortran_env module. I have drafted my solution in this patch where I declare a variable with the value of atomic_int_kind but with the bind(c) attribute in a new Fortran module and then use an extern int in a .h file to theoretically grab that value. However, I have not done much Fortran/C interoperability and am not sure how to do the right CMake changes to make my idea work. At the moment, I commented out the extern int and am just using a magic number. Would anyone be able to help me figure out how to make the right CMake changes so I can use that extern int? Or is there a totally different and better way to get a value equivalent to atomic_int_kind that is not a magic number?

Thu, Sep 1, 6:01 PM · Restricted Project, Restricted Project, Restricted Project
ktras added a reviewer for D133174: [flang] Add atomic_fetch_or to the list of intrinsics: awarzynski.
Thu, Sep 1, 5:54 PM · Restricted Project, Restricted Project, Restricted Project
ktras retitled D133139: [flang] Write semantics test for atomic_fetch_add from Write semantics test for atomic_fetch_add to [flang] Write semantics test for atomic_fetch_add.
Thu, Sep 1, 5:53 PM · Restricted Project, Restricted Project, Restricted Project
ktras requested review of D133174: [flang] Add atomic_fetch_or to the list of intrinsics.
Thu, Sep 1, 5:50 PM · Restricted Project, Restricted Project, Restricted Project
ktras added a comment to D114134: [flang] Add co_sum to the list of intrinsics and update test.

@jeanPerier I have updated this differential since you approved it, would you like to check the changes? My new function now just checks one ActualArgument to make sure it is not a coindexed-object, instead of a list of ActualArguments. This fixes some test failures I was getting, and also I think matches better the needs of the other subroutines that will need to call this function, like the atomic subroutines, which all have only one ActualArgument that shall not be coindexed.

Thu, Sep 1, 5:44 PM · Restricted Project, Restricted Project, Restricted Project
ktras committed rG7dbbf77e1f18: [flang] Add lcobound and ucobound to the list of intrinsics (authored by ktras).
[flang] Add lcobound and ucobound to the list of intrinsics
Thu, Sep 1, 5:22 PM · Restricted Project, Restricted Project
ktras closed D126721: [flang] Add lcobound and ucobound to the list of intrinsics.
Thu, Sep 1, 5:22 PM · Restricted Project, Restricted Project, Restricted Project
ktras added inline comments to D126721: [flang] Add lcobound and ucobound to the list of intrinsics.
Thu, Sep 1, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
ktras updated the diff for D126721: [flang] Add lcobound and ucobound to the list of intrinsics.

Update name of new enumerator to make its purpose more clear.

Thu, Sep 1, 2:22 PM · Restricted Project, Restricted Project, Restricted Project
ktras added a comment to D126721: [flang] Add lcobound and ucobound to the list of intrinsics.

@klausler, @jeanPerier, @PeteSteinfeld Would anyone else like to look this over before I push?

Thu, Sep 1, 12:30 PM · Restricted Project, Restricted Project, Restricted Project
ktras requested review of D133139: [flang] Write semantics test for atomic_fetch_add.
Thu, Sep 1, 12:20 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Aug 31

ktras retitled D133070: [flang] Add check for constraints on sync-stat-lists and other constraints in sync-images-stmt, and event statements from [flang] Add check for constraints on `sync-stat-lists` and other constraints in `sync-images-stmt`, and event statements to [flang] Add check for constraints on sync-stat-lists and other constraints in sync-images-stmt, and event statements.
Wed, Aug 31, 4:46 PM · Restricted Project, Restricted Project, Restricted Project
ktras requested review of D133070: [flang] Add check for constraints on sync-stat-lists and other constraints in sync-images-stmt, and event statements.
Wed, Aug 31, 4:39 PM · Restricted Project, Restricted Project, Restricted Project
ktras committed rG183f1b568527: [flang] Write semantics test for atomic_fetch_or (authored by ktras).
[flang] Write semantics test for atomic_fetch_or
Wed, Aug 31, 12:03 PM · Restricted Project, Restricted Project
ktras closed D132519: [flang] Write semantics test for atomic_fetch_or.
Wed, Aug 31, 12:02 PM · Restricted Project, Restricted Project, Restricted Project
ktras updated the diff for D114134: [flang] Add co_sum to the list of intrinsics and update test.

Remove unnecessary if-stmt in new function, CheckForCoindexedObjects.

Wed, Aug 31, 10:58 AM · Restricted Project, Restricted Project, Restricted Project

Aug 30 2022

ktras updated the diff for D132519: [flang] Write semantics test for atomic_fetch_or.

Make changes in test based on feedback.

Aug 30 2022, 1:24 PM · Restricted Project, Restricted Project, Restricted Project

Aug 29 2022

ktras updated the diff for D114134: [flang] Add co_sum to the list of intrinsics and update test.

Forgot to run git-clang-format after one last small change I made, so this updated diff fixes the one line changed by git-clang-format.

Aug 29 2022, 9:33 AM · Restricted Project, Restricted Project, Restricted Project

Aug 28 2022

ktras added a comment to rG21dceb3ca67c: [flang] Split up synchronization, event, and error stop stmt tests.

I forgot the add the differential url in the commit message, but the differential is here.

Aug 28 2022, 10:58 AM · Restricted Project, Restricted Project
ktras closed D132401: [flang] Split up synchronization, event, and error stop stmt tests.

I pushed these changes but I forgot to include the differential revision in the commit message for the commit 21dceb3ca67c. This closes this differential.

Aug 28 2022, 10:44 AM · Restricted Project, Restricted Project, Restricted Project
ktras committed rG21dceb3ca67c: [flang] Split up synchronization, event, and error stop stmt tests (authored by ktras).
[flang] Split up synchronization, event, and error stop stmt tests
Aug 28 2022, 10:41 AM · Restricted Project, Restricted Project

Aug 24 2022

ktras updated the diff for D132401: [flang] Split up synchronization, event, and error stop stmt tests.

Fix comments just updated.

Aug 24 2022, 4:53 PM · Restricted Project, Restricted Project, Restricted Project
ktras updated the diff for D132401: [flang] Split up synchronization, event, and error stop stmt tests.

Updated comments in some of the tests based on reviewer's feedback.

Aug 24 2022, 4:50 PM · Restricted Project, Restricted Project, Restricted Project
ktras updated the diff for D114134: [flang] Add co_sum to the list of intrinsics and update test.

Updated the new function CheckForCoindexedObjects (and renamed it CheckForCoindexedObject) to take one ActualArgument and to check just that argument for a coindexed object. This fixes the non-deterministic test failure I was finding with my previous implementation, plus it also is a better function for when I add the atomic subroutines and use it to check only one of their arguments.

Aug 24 2022, 4:30 PM · Restricted Project, Restricted Project, Restricted Project

Aug 23 2022

ktras requested review of D132519: [flang] Write semantics test for atomic_fetch_or.
Aug 23 2022, 5:54 PM · Restricted Project, Restricted Project, Restricted Project
ktras accepted D131535: [flang] Add semantics test for atomic_add subroutine.

LGTM

Aug 23 2022, 4:52 PM · Restricted Project, Restricted Project, Restricted Project
ktras updated the diff for D126721: [flang] Add lcobound and ucobound to the list of intrinsics.
  • Add ucobound to the list of intrinsics and update the semantics test with the ERROR directives and with more examples of valid and invalid code
  • Add function to ensure that if the optional dim argument is present and statically checkable, its value is in the inclusive range of 1 and the corank of the coarray argument
  • Add more examples of valid and invalid code to the semantics test for lcobound
Aug 23 2022, 12:02 PM · Restricted Project, Restricted Project, Restricted Project

Aug 22 2022

ktras requested review of D132401: [flang] Split up synchronization, event, and error stop stmt tests.
Aug 22 2022, 10:59 AM · Restricted Project, Restricted Project, Restricted Project

Aug 16 2022

ktras requested changes to D131535: [flang] Add semantics test for atomic_add subroutine.

The test looks great, please see the couple of suggestions in the in line comments.

Aug 16 2022, 2:57 PM · Restricted Project, Restricted Project, Restricted Project

Aug 9 2022

ktras accepted D131211: [flang] Add semantics test for event_query subroutine.

LGTM!

Aug 9 2022, 1:07 PM · Restricted Project, Restricted Project, Restricted Project

Aug 2 2022

ktras added a comment to D129513: [flang] Add `stopped_images` to list of intrinsics and add test.

Thanks for the review @klausler.

Aug 2 2022, 5:02 PM · Restricted Project, Restricted Project, Restricted Project
ktras committed rG6ac30fa6e941: [flang] Add stopped_images to list of intrinsics and add test (authored by ktras).
[flang] Add stopped_images to list of intrinsics and add test
Aug 2 2022, 5:02 PM · Restricted Project, Restricted Project
ktras closed D129513: [flang] Add `stopped_images` to list of intrinsics and add test.
Aug 2 2022, 5:01 PM · Restricted Project, Restricted Project, Restricted Project

Aug 1 2022

ktras added a comment to D129513: [flang] Add `stopped_images` to list of intrinsics and add test.

Thanks @ngeorge1098 for reviewing the test.

Aug 1 2022, 10:49 AM · Restricted Project, Restricted Project, Restricted Project
ktras accepted D130530: [flang] Add semantics test for ERROR STOP statement.

LGTM

Aug 1 2022, 9:53 AM · Restricted Project, Restricted Project, Restricted Project

Jul 28 2022

ktras added a comment to D130530: [flang] Add semantics test for ERROR STOP statement.

Test looks great, but I would suggest adding non-conforming statements where the stop-code is not of the default integer kind, thus testing C1171 from the Fortran 2018 Standard, and adding a stop-code where it is not of the default char kind, thus testing the definition of one of the options for a stop code, which is scalar-default-char-expr.

Jul 28 2022, 1:26 PM · Restricted Project, Restricted Project, Restricted Project

Jul 27 2022

ktras accepted D130608: [flang] Add semantics test for EVENT WAIT statement.

LGTM

Jul 27 2022, 5:10 PM · Restricted Project, Restricted Project, Restricted Project
ktras updated the diff for D129513: [flang] Add `stopped_images` to list of intrinsics and add test.

Add additional non-conforming statements to the stopped_images test.

Jul 27 2022, 4:44 PM · Restricted Project, Restricted Project, Restricted Project

Jul 14 2022

ktras reopened D114134: [flang] Add co_sum to the list of intrinsics and update test.

I pushed this change today and had to revert the commit because it caused some unexpected test failures. The three tests that failed on the buildbots (though these tests didn't consistently fail across the different buildbots) were all flang semantics tests and are:

Jul 14 2022, 3:48 PM · Restricted Project, Restricted Project, Restricted Project
ktras added a reverting change for rGd2460d90080f: [flang] Add co_sum to the list of intrinsics and update test: rGebf3dbbe1543: Revert "[flang] Add co_sum to the list of intrinsics and update test".
Jul 14 2022, 2:46 PM · Restricted Project, Restricted Project
ktras committed rGebf3dbbe1543: Revert "[flang] Add co_sum to the list of intrinsics and update test" (authored by ktras).
Revert "[flang] Add co_sum to the list of intrinsics and update test"
Jul 14 2022, 2:46 PM · Restricted Project, Restricted Project
ktras added a reverting change for D114134: [flang] Add co_sum to the list of intrinsics and update test: rGebf3dbbe1543: Revert "[flang] Add co_sum to the list of intrinsics and update test".
Jul 14 2022, 2:45 PM · Restricted Project, Restricted Project, Restricted Project
ktras committed rGd2460d90080f: [flang] Add co_sum to the list of intrinsics and update test (authored by ktras).
[flang] Add co_sum to the list of intrinsics and update test
Jul 14 2022, 1:50 PM · Restricted Project, Restricted Project
ktras closed D114134: [flang] Add co_sum to the list of intrinsics and update test.
Jul 14 2022, 1:50 PM · Restricted Project, Restricted Project, Restricted Project
ktras added a comment to D114134: [flang] Add co_sum to the list of intrinsics and update test.

@jeanPerier Thanks for the review!

Jul 14 2022, 1:49 PM · Restricted Project, Restricted Project, Restricted Project
ktras accepted D129515: [flang] Add semantics test for EVENT POST statement.

LGTM

Jul 14 2022, 11:46 AM · Restricted Project, Restricted Project, Restricted Project

Jul 12 2022

ktras updated the diff for D114134: [flang] Add co_sum to the list of intrinsics and update test.

Move check for coindexed objects for certain arguments in co_sum and move_alloc to a new function CheckForCoindexedObjects, which is called from ApplySpecificChecks for the specific cases of co_sum and move_alloc. Add some calls to the semantics tests to better check this implementation.

Jul 12 2022, 10:03 AM · Restricted Project, Restricted Project, Restricted Project

Jul 11 2022

ktras requested review of D129513: [flang] Add `stopped_images` to list of intrinsics and add test.
Jul 11 2022, 1:20 PM · Restricted Project, Restricted Project, Restricted Project
ktras committed rG9bb18a983f2f: [flang] Add semantics test for image_status and add a check (authored by ktras).
[flang] Add semantics test for image_status and add a check
Jul 11 2022, 10:55 AM · Restricted Project, Restricted Project
ktras closed D128009: [flang] Add semantics test for image_status and add a check.
Jul 11 2022, 10:55 AM · Restricted Project, Restricted Project, Restricted Project

Jul 7 2022

ktras added a comment to D128009: [flang] Add semantics test for image_status and add a check.

@klausler Thanks for the review.

Jul 7 2022, 11:07 AM · Restricted Project, Restricted Project, Restricted Project

Jul 6 2022

ktras added a comment to D128009: [flang] Add semantics test for image_status and add a check.

@klausler Thank you for the suggested usage of std::decay_t. I didn't want to deal with the kind codes through hardcoding, so thank you for helping me see how could I deal with them through an abstraction in that context. Also, thank you for the suggested error message. That is much more concise than the versions I came up with!

Jul 6 2022, 4:59 PM · Restricted Project, Restricted Project, Restricted Project
ktras updated the diff for D128009: [flang] Add semantics test for image_status and add a check.

Replaced the hardcoded dealing with the different kind codes in Expr<SomeInteger> with dealing with them through an abstraction.

Jul 6 2022, 4:55 PM · Restricted Project, Restricted Project, Restricted Project
ktras added a comment to D128009: [flang] Add semantics test for image_status and add a check.

@klausler I did try to come up with an error message that included the actual value that was passed, but I couldn't come up with any message that was concise or that I liked better than the current error message. I am of course open to suggestions. And thank you for your feedback on the better way to access the object inside of an std::optional.

Jul 6 2022, 11:52 AM · Restricted Project, Restricted Project, Restricted Project
ktras updated the diff for D128009: [flang] Add semantics test for image_status and add a check.

Added a check for non positive values if an array is passed to the image argument of image_status or the size argument of ishftc.

Jul 6 2022, 11:47 AM · Restricted Project, Restricted Project, Restricted Project