Page MenuHomePhabricator

craig.rasmussen (Craig E Rasmussen)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 20 2021, 12:59 PM (93 w, 4 d)

Recent Activity

Aug 31 2022

craig.rasmussen accepted D126721: [flang] Add lcobound and ucobound to the list of intrinsics.

LGTM

Aug 31 2022, 10:45 AM · Restricted Project, Restricted Project, Restricted Project

Jun 1 2022

craig.rasmussen requested changes to D126721: [flang] Add lcobound and ucobound to the list of intrinsics.
Jun 1 2022, 6:42 PM · Restricted Project, Restricted Project, Restricted Project
craig.rasmussen accepted D126734: [flang] Add team_type to num_images intrinsic call.

Looks good to me.

Jun 1 2022, 6:33 PM · Restricted Project, Restricted Project, Restricted Project
craig.rasmussen added inline comments to D126734: [flang] Add team_type to num_images intrinsic call.
Jun 1 2022, 1:30 PM · Restricted Project, Restricted Project, Restricted Project

Nov 3 2021

craig.rasmussen added a comment to D113077: [flang] Add a semantics test for co_min.

I'm guessing that this won't pass "git clang-format" (although I don't know if test files are checked. I'll check and let you know offline.

Nov 3 2021, 11:10 AM · Restricted Project, Restricted Project

Oct 4 2021

craig.rasmussen committed rG18e63289358f: [flang] Remove incorrect unit test (authored by craig.rasmussen).
[flang] Remove incorrect unit test
Oct 4 2021, 6:27 PM
craig.rasmussen committed rG9dd3965e96d1: [flang] Added tests for intrinsic function 'team_number()' (authored by craig.rasmussen).
[flang] Added tests for intrinsic function 'team_number()'
Oct 4 2021, 12:40 PM
craig.rasmussen closed D100897: [flang] Make 'team_number()' an intrinsic function.
Oct 4 2021, 12:39 PM · Restricted Project, Restricted Project

Sep 29 2021

craig.rasmussen updated the diff for D100897: [flang] Make 'team_number()' an intrinsic function.

Update based on changes in https://reviews.llvm.org/D110356. Cleaned up tests.

Sep 29 2021, 9:57 PM · Restricted Project, Restricted Project

Sep 28 2021

craig.rasmussen added a comment to D110356: [flang] Make builtin types more easily accessible; use them.

Craig R.: any comments?

Oh, you actually want me to comment on the change? I think you probably want me to use it. I need to take some time to digest the changes.

Would you like me to wait for your review comments before landing this patch?

Sep 28 2021, 5:13 PM · Restricted Project, Restricted Project

Sep 27 2021

craig.rasmussen added a comment to D100897: [flang] Make 'team_number()' an intrinsic function.

This needs to be updated for changes in https://reviews.llvm.org/D110356

Sep 27 2021, 4:48 PM · Restricted Project, Restricted Project
craig.rasmussen added a comment to D110356: [flang] Make builtin types more easily accessible; use them.

Craig R.: any comments?

Sep 27 2021, 4:41 PM · Restricted Project, Restricted Project
craig.rasmussen added inline comments to D100897: [flang] Make 'team_number()' an intrinsic function.
Sep 27 2021, 4:18 PM · Restricted Project, Restricted Project
craig.rasmussen updated the diff for D100897: [flang] Make 'team_number()' an intrinsic function.

Inlined implementation of call to semantics::IsTeamType. This is necessary because the semantics::IsTeamType symbol in undefined at the time libFortranEvalute is built.

Sep 27 2021, 4:11 PM · Restricted Project, Restricted Project
craig.rasmussen added inline comments to D100897: [flang] Make 'team_number()' an intrinsic function.
Sep 27 2021, 2:06 PM · Restricted Project, Restricted Project

Sep 21 2021

craig.rasmussen added a reviewer for D100897: [flang] Make 'team_number()' an intrinsic function: jeanPerier.
Sep 21 2021, 3:16 PM · Restricted Project, Restricted Project

Sep 20 2021

craig.rasmussen updated the summary of D100897: [flang] Make 'team_number()' an intrinsic function.
Sep 20 2021, 1:34 PM · Restricted Project, Restricted Project
craig.rasmussen updated the diff for D100897: [flang] Make 'team_number()' an intrinsic function.

Implemented TEAM_NUMBER intrinsic function without use of MissingDerivedType() hack.

Sep 20 2021, 1:28 PM · Restricted Project, Restricted Project

Sep 16 2021

craig.rasmussen committed rGed921282e551: [flang] Make 'this_image()' an intrinsic function (authored by craig.rasmussen).
[flang] Make 'this_image()' an intrinsic function
Sep 16 2021, 10:19 PM
craig.rasmussen added a comment to D109547: [flang] Add runtime interface for NUM_IMAGES.

Hopefully this will open the issue and is the correct way to correct a push that was reverted.

Sep 16 2021, 3:13 PM · Restricted Project
craig.rasmussen updated the diff for D109547: [flang] Add runtime interface for NUM_IMAGES.

Inlined call to Fortran::semantics::IsCoarray (one line change) to fix link error.

Sep 16 2021, 3:06 PM · Restricted Project

Sep 13 2021

craig.rasmussen updated subscribers of D109547: [flang] Add runtime interface for NUM_IMAGES.

Peter Klausler wrote:

Or you could have two entry points, one with a team number and one without, and avoid exposing this kind of trick in the API. It could still be used as a hidden part of a common implementation.

Sep 13 2021, 4:08 PM · Restricted Project
craig.rasmussen updated the diff for D109547: [flang] Add runtime interface for NUM_IMAGES.

Added comments explaining why team_number=0 is a good default value when NUM_IMAGES is called without an actual argument for TEAM_NUMBER.

Sep 13 2021, 12:34 PM · Restricted Project
craig.rasmussen updated the diff for D109547: [flang] Add runtime interface for NUM_IMAGES.

Changed location of header file to flang/include/flang/Runtime/coarray.h.

Sep 13 2021, 12:14 PM · Restricted Project

Sep 9 2021

craig.rasmussen added inline comments to D109547: [flang] Add runtime interface for NUM_IMAGES.
Sep 9 2021, 3:14 PM · Restricted Project
craig.rasmussen requested review of D109547: [flang] Add runtime interface for NUM_IMAGES.
Sep 9 2021, 2:52 PM · Restricted Project
craig.rasmussen added a comment to D100897: [flang] Make 'team_number()' an intrinsic function.

In a response @klausler asked:

Sep 9 2021, 2:45 PM · Restricted Project, Restricted Project
craig.rasmussen added a reviewer for D100897: [flang] Make 'team_number()' an intrinsic function: PeteSteinfeld.
Sep 9 2021, 2:29 PM · Restricted Project, Restricted Project
craig.rasmussen added a reviewer for D108059: [flang] Make 'this_image()' an intrinsic function: PeteSteinfeld.
Sep 9 2021, 2:28 PM · Restricted Project, Restricted Project

Sep 3 2021

craig.rasmussen added a comment to D100897: [flang] Make 'team_number()' an intrinsic function.

@klausler, are any further changes required to get this approved?

Sep 3 2021, 11:30 AM · Restricted Project, Restricted Project

Aug 18 2021

craig.rasmussen added a comment to D105595: [flang] Compile error instantiating std::clock_t on Apple clang version 11.0.0.

ping

Aug 18 2021, 11:28 AM · Restricted Project

Aug 13 2021

craig.rasmussen requested review of D108059: [flang] Make 'this_image()' an intrinsic function.
Aug 13 2021, 4:00 PM · Restricted Project, Restricted Project

Aug 2 2021

craig.rasmussen updated the diff for D100897: [flang] Make 'team_number()' an intrinsic function.
  1. Added "! REQUIRES: shell" to test file so as not to trip on windows
  2. Ran git clang-format
Aug 2 2021, 2:41 PM · Restricted Project, Restricted Project

Jul 26 2021

craig.rasmussen added a comment to D105595: [flang] Compile error instantiating std::clock_t on Apple clang version 11.0.0.

How do I ping? I have another pull request that is also in limbo.

Jul 26 2021, 12:12 PM · Restricted Project

Jul 21 2021

craig.rasmussen added a comment to D105595: [flang] Compile error instantiating std::clock_t on Apple clang version 11.0.0.

Requesting review (is there a better way to request a review)

Jul 21 2021, 4:06 PM · Restricted Project
craig.rasmussen updated the diff for D105595: [flang] Compile error instantiating std::clock_t on Apple clang version 11.0.0.

Made simplification suggested by reviewer:

Jul 21 2021, 11:09 AM · Restricted Project

Jul 8 2021

craig.rasmussen added inline comments to D100897: [flang] Make 'team_number()' an intrinsic function.
Jul 8 2021, 12:07 PM · Restricted Project, Restricted Project
craig.rasmussen added a comment to D105595: [flang] Compile error instantiating std::clock_t on Apple clang version 11.0.0.

Fixed patch and added reviewer.

Jul 8 2021, 11:51 AM · Restricted Project
craig.rasmussen added reviewers for D105595: [flang] Compile error instantiating std::clock_t on Apple clang version 11.0.0: jhenderson, sscalpone.
Jul 8 2021, 11:50 AM · Restricted Project
craig.rasmussen updated the diff for D105595: [flang] Compile error instantiating std::clock_t on Apple clang version 11.0.0.

Forgot to commit changes so patch/diff was not correct.

Jul 8 2021, 11:47 AM · Restricted Project

Jul 7 2021

craig.rasmussen updated the summary of D105595: [flang] Compile error instantiating std::clock_t on Apple clang version 11.0.0.
Jul 7 2021, 2:57 PM · Restricted Project
craig.rasmussen requested review of D105595: [flang] Compile error instantiating std::clock_t on Apple clang version 11.0.0.
Jul 7 2021, 2:51 PM · Restricted Project
craig.rasmussen added inline comments to D100897: [flang] Make 'team_number()' an intrinsic function.
Jul 7 2021, 1:26 PM · Restricted Project, Restricted Project
craig.rasmussen added a comment to D100897: [flang] Make 'team_number()' an intrinsic function.

Added line comments.

Jul 7 2021, 12:46 PM · Restricted Project, Restricted Project
craig.rasmussen updated the diff for D100897: [flang] Make 'team_number()' an intrinsic function.

Added the static function MissingDerivedType() to allow the creation of a DynamicType with TypeCategory::Derived when a semantics::DerivedTypeSpec is not directly available. This allows a missing actual argument for an optional dummy.

Jul 7 2021, 12:23 PM · Restricted Project, Restricted Project

Apr 28 2021

craig.rasmussen added a comment to D100897: [flang] Make 'team_number()' an intrinsic function.

I forgot to add that there is one test failing at the moment which makes no sense to me.

Apr 28 2021, 10:31 AM · Restricted Project, Restricted Project
craig.rasmussen added inline comments to D100897: [flang] Make 'team_number()' an intrinsic function.
Apr 28 2021, 10:11 AM · Restricted Project, Restricted Project
craig.rasmussen updated the diff for D100897: [flang] Make 'team_number()' an intrinsic function.
  1. Fixed team argument in call to team_number so that it is optional.
  2. Fixed teamType kind in flang/lib/Evaluate/intrinsics.cpp
  3. Added team_number test to flang/unittests/Evaluate/intrinsics.cpp
Apr 28 2021, 10:06 AM · Restricted Project, Restricted Project

Apr 20 2021

craig.rasmussen added inline comments to D100897: [flang] Make 'team_number()' an intrinsic function.
Apr 20 2021, 3:49 PM · Restricted Project, Restricted Project
craig.rasmussen requested review of D100897: [flang] Make 'team_number()' an intrinsic function.
Apr 20 2021, 3:27 PM · Restricted Project, Restricted Project