Page MenuHomePhabricator

[flang] Add team_type to num_images intrinsic call

Authored by ktras on May 31 2022, 5:03 PM.



num_images had previously been added to the list of intrinsics
before the type team_type had been implemented. Now that team_type
is implemented, add the num_images call that has the team argument.
Update the semantics tests for num_images.

Diff Detail

Event Timeline

ktras created this revision.May 31 2022, 5:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2022, 5:03 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript
ktras requested review of this revision.May 31 2022, 5:03 PM
craig.rasmussen added inline comments.Jun 1 2022, 1:30 PM

It looks like this comment should go away.

ktras updated this revision to Diff 433600.Jun 1 2022, 5:38 PM
ktras edited the summary of this revision. (Show Details)
  • In the semantics test, remove section of comment that says "not yet supported" when referring to the team argument
  • Fix the formatting in the changes in flang/lib/Evaluate/intrinsics.cpp after running git clang-format

Thank you for catching that! I have now removed the "not yet supported" part of that comment.

ktras marked an inline comment as done.Jun 1 2022, 5:39 PM
craig.rasmussen accepted this revision.Jun 1 2022, 6:33 PM

Looks good to me.

This revision is now accepted and ready to land.Jun 1 2022, 6:33 PM
ktras added a comment.Jun 6 2022, 9:40 AM

I don't have push permissions, so if there is no more feedback on this differential, can someone push this to main for me please?

This revision was automatically updated to reflect the committed changes.