This patch supports to convert the llvm intrinsic to the correspond op. It still leaves some intrinsics to be handle specially.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Thanks!
mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp | ||
---|---|---|
658 | Please add documentation. | |
965 | ||
mlir/test/Target/LLVMIR/Import/intrinsic.ll | ||
13 | Do not pattern-match SSA value names, here and below. We don't actually care about names here so something like %{{.+}} should be sufficient. | |
464 | Not: could we have the check line next to the line that is being translated? |
Thanks for adding this support. I only have some minor comments.
mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td | ||
---|---|---|
289 | I feel like "id" is a little ambiguous, what about "llvmEnumName"? | |
mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp | ||
968 | I think it's better to spell out auto on this line. | |
1167 | ditto | |
mlir/test/Target/LLVMIR/Import/intrinsic.ll | ||
4 | Are you intend to add CHECK-s for this function as well? |
mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp | ||
---|---|---|
658 | Nit: this returns StringRef, not OperationName. |
I feel like "id" is a little ambiguous, what about "llvmEnumName"?