Page MenuHomePhabricator

[ccache] Add Windows support
ClosedPublic

Authored by NathanielMcVicar on May 27 2022, 3:44 PM.

Details

Summary

Windows builds can't receive environment variables on the command line or make use of RULE_LAUNCH_COMPILE with ccache.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2022, 3:44 PM
Herald added a subscriber: mgorny. · View Herald Transcript
NathanielMcVicar requested review of this revision.May 27 2022, 3:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2022, 3:44 PM

I know nothing about ccache on Windows, but if it didn't work before, I think it is pretty clear that this at least won't cause any sort of regression.

Ericson2314 accepted this revision.Tue, May 31, 1:29 PM

So ideally someone else reviews this, but if not, +1 from me as at least no worse than before.

This revision is now accepted and ready to land.Tue, May 31, 1:29 PM
stella.stamenova accepted this revision.Tue, May 31, 4:13 PM

LGTM

llvm/CMakeLists.txt
195

Can you add a comment that we can't use RULE_LAUNCH_COMPILE on Windows even though in theory it should be able to work?

Add comment for RULE_LAUNCH_COMPILE on Windows

NathanielMcVicar marked an inline comment as done.

Fix merge base

This revision was landed with ongoing or failed builds.Wed, Jun 1, 11:35 AM
This revision was automatically updated to reflect the committed changes.