[OpenMP] allow loc to be NULL in __kmp_determine_reduction_method to accommodate MSVC

[vadikp-intel]

Summary

MSVC may not supply source location information to kmpc_reduce passing NULL for the value. The patch adds a check for the loc value being NULL in kmp_determine_reduction_method.

[jlpeyton]

openmp/runtime/src/kmp_runtime.cpp

8710

Can you run clang-format on this line and make sure it is less than 80 chars long?

[vadikp-intel]

clang-formatted the previous version

[jlpeyton]

LGTM

[vadikp-intel]

The patch looks to be ready to go in. Could someone with access please commit it? Thanks

openmp/runtime/src/kmp_runtime.cpp

#if USE_ITT_NOTIFY
           tmp_time = __itt_get_timestamp();
         // Internal fork - report frame begin
         master_th->th.th_frame_time = tmp_time;
         if (__kmp_forkjoin_frames_mode == 3)
           team->t.t_region_time = tmp_time;
       } else
 // only one notification scheme (either "submit" or "forking/joined", not both)
 #endif /* USE_ITT_NOTIFY */
-          if ((__itt_frame_begin_v3_ptr || KMP_ITT_DEBUG) &&
-              __kmp_forkjoin_frames && !__kmp_forkjoin_frames_mode) {
           // Mark start of "parallel" region for Intel(R) VTune(TM) analyzer.
           __kmp_itt_region_forking(gtid, team->t.t_nproc, 0);
         }
     }
 #endif /* USE_ITT_BUILD */
 
     /* now go on and do the work */
     KMP_DEBUG_ASSERT(team == __kmp_threads[gtid]->th.th_team);
     KMP_MB();
     KF_TRACE(10,
              ("__kmp_internal_fork : root=%p, team=%p, master_th=%p, gtid=%d\n",
root_team =
                           1, // new_nproc
                           1, // max_nproc
 #if OMPT_SUPPORT
                           ompt_data_none, // root parallel id
 #endif
                           __kmp_nested_proc_bind.bind_types[0], &r_icvs,
                           0 // argc
                           USE_NESTED_HOT_ARG(NULL) // primary thread is unknown
-                          );
 #if USE_DEBUGGER
   // Non-NULL value should be assigned to make the debugger display the root
   // team.
   TCW_SYNC_PTR(root_team->t.t_pkfn, (microtask_t)(~0));
 #endif
 
   KF_TRACE(10, ("__kmp_initialize_root: after root_team = %p\n", root_team));
 
hot_team =
                           1, // new_nproc
                           __kmp_dflt_team_nth_ub * 2, // max_nproc
 #if OMPT_SUPPORT
                           ompt_data_none, // root parallel id
 #endif
                           __kmp_nested_proc_bind.bind_types[0], &r_icvs,
                           0 // argc
                           USE_NESTED_HOT_ARG(NULL) // primary thread is unknown
-                          );
   KF_TRACE(10, ("__kmp_initialize_root: after hot_team = %p\n", hot_team));
 
   root->r.r_hot_team = hot_team;
   root_team->t.t_control_stack_top = NULL;
 
   /* first-time initialization */
   hot_team->t.t_parent = root_team;
 
__kmp_determine_reduction_method(
   PACKED_REDUCTION_METHOD_T retval;
 
   int team_size;
 
   KMP_DEBUG_ASSERT(loc); // it would be nice to test ( loc != 0 )
   KMP_DEBUG_ASSERT(lck); // it would be nice to test ( lck != 0 )
 
 #define FAST_REDUCTION_ATOMIC_METHOD_GENERATED                                 \
-  ((loc->flags & (KMP_IDENT_ATOMIC_REDUCE)) == (KMP_IDENT_ATOMIC_REDUCE))
+  (loc &&                                                                      \
+   ((loc->flags & (KMP_IDENT_ATOMIC_REDUCE)) == (KMP_IDENT_ATOMIC_REDUCE)))
 #define FAST_REDUCTION_TREE_METHOD_GENERATED ((reduce_data) && (reduce_func))
 
   retval = critical_reduce_block;
 
   // another choice of getting a team size (with 1 dynamic deference) is slower
   team_size = __kmp_get_team_num_threads(global_tid);
   if (team_size == 1) {