This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] allow loc to be NULL in __kmp_determine_reduction_method to accommodate MSVC

Authored by vadikp-intel on May 27 2022, 1:35 PM.



MSVC may not supply source location information to kmpc_reduce passing NULL for the value. The patch adds a check for the loc value being NULL in kmp_determine_reduction_method.

Diff Detail

Event Timeline

vadikp-intel created this revision.May 27 2022, 1:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2022, 1:35 PM
vadikp-intel requested review of this revision.May 27 2022, 1:35 PM
jlpeyton added inline comments.May 31 2022, 12:05 PM

Can you run clang-format on this line and make sure it is less than 80 chars long?

clang-formatted the previous version

jlpeyton accepted this revision.Jun 1 2022, 8:39 AM


This revision is now accepted and ready to land.Jun 1 2022, 8:39 AM
vadikp-intel marked an inline comment as done.Jun 2 2022, 5:58 PM

The patch looks to be ready to go in. Could someone with access please commit it? Thanks