[OpenMP] Pass chunk-size to MLIR while lowering from parse-tree
ClosedPublic
Actions

Authored by Leporacanthicus on May 25 2022, 7:59 AM.

Details

Reviewers

jdoerfert
kiranchandramohan
peixin
shraiysh

Commits

rG820146abe908: [OpenMP] Pass chunk-size to MLIR while lowering from parse-tree

Summary

Test that chunk size is passed to the static init function.
Using three different variations:

Single constant.
Expression with constants.
Variable value.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Leporacanthicus created this revision.May 25 2022, 7:59 AM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 25 2022, 7:59 AM

Herald added subscribers: bzcheeseman, Chia-hungDuan, mehdi_amini and 3 others. · View Herald Transcript

Leporacanthicus requested review of this revision.May 25 2022, 7:59 AM

Herald added a reviewer: jdoerfert. · View Herald TranscriptMay 25 2022, 7:59 AM

Herald added subscribers: sstefan1, stephenneuendorffer, jdoerfert. · View Herald Transcript

Leporacanthicus added reviewers: kiranchandramohan, peixin, shraiysh.May 25 2022, 8:02 AM

Harbormaster completed remote builds in B166275: Diff 431998.May 25 2022, 8:25 AM

The code LGTM. The test should be from F90 to MLIR (FIR + OpenMP Dialect) only. Lowering to LLVM IR from FIR and OpenMP Dialect is tested separately.

shraiysh requested changes to this revision.May 25 2022, 11:17 AM

This revision now requires changes to proceed.May 25 2022, 11:17 AM

Update test to MLIR

LGTM

Harbormaster completed remote builds in B166451: Diff 432242.May 26 2022, 4:17 AM

Yup this looks okay to me now. Thank you!

This revision is now accepted and ready to land.May 26 2022, 6:51 AM

Removed some unnecessary test-lines [testing for variables used nowhere else
and constants used to set up the I/O, where the call itself is not tested]

Harbormaster completed remote builds in B166885: Diff 432882.May 30 2022, 4:06 AM

Closed by commit rG820146abe908: [OpenMP] Pass chunk-size to MLIR while lowering from parse-tree (authored by MatsPetersson). · Explain WhyMay 30 2022, 4:15 AM

This revision was automatically updated to reflect the committed changes.

MatsPetersson added a commit: rG820146abe908: [OpenMP] Pass chunk-size to MLIR while lowering from parse-tree.

Revision Contents
Changeset List

Path

Size

flang/

lib/

Lower/

OpenMP.cpp

16 lines

test/

Lower/

OpenMP/

omp-wsloop-chunks.f90

69 lines

Diff 432883

View Options

flang/lib/Lower/OpenMP.cpp