This is an archive of the discontinued LLVM Phabricator instance.

Differential D126130

[analyzer][NFC] Remove unused SVal::hasConjuredSymbol
ClosedPublic

Authored by steakhal on May 21 2022, 12:14 PM.

Details

Reviewers
martong
NoQ
Szelethus
Commits
rG813acb12972e: [analyzer][NFC] Remove unused SVal::hasConjuredSymbol

Diff Detail

Event Timeline

steakhal created this revision.May 21 2022, 12:14 PM
Herald added a reviewer: Szelethus. · View Herald TranscriptMay 21 2022, 12:14 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: manas, ASDenysPetrov, dkrupp and 8 others. · View Herald Transcript
steakhal requested review of this revision.May 21 2022, 12:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2022, 12:14 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
steakhal updated this revision to Diff 431164.May 21 2022, 12:15 PM
This comment was removed by steakhal.
steakhal added a parent revision: D126129: [analyzer][NFC] Remove unused nonloc::ConcreteInt::evalBinOp.May 21 2022, 12:23 PM
steakhal added a child revision: D126123: [analyzer][NFC] Use MemRegion::getRegion()'s return value unconditionally.
Harbormaster completed remote builds in B165675: Diff 431164.May 21 2022, 1:10 PM
martong added a comment.May 23 2022, 5:00 AM

Remove unused SVal::hasConjuredSymbol

The title seems to be off with the changes.

steakhal updated this revision to Diff 431344.May 23 2022, 5:23 AM

upload the right diff

steakhal added a comment.May 23 2022, 5:23 AM
In D126130#3531108, @martong wrote:

Remove unused SVal::hasConjuredSymbol

The title seems to be off with the changes.

Ah, right. Once I tried using arc, and I get everything messed up. Never again!

martong accepted this revision.May 23 2022, 5:32 AM
This revision is now accepted and ready to land.May 23 2022, 5:32 AM
Harbormaster completed remote builds in B165819: Diff 431344.May 23 2022, 5:54 AM
Closed by commit rG813acb12972e: [analyzer][NFC] Remove unused SVal::hasConjuredSymbol (authored by steakhal). · Explain WhyMay 27 2022, 1:08 AM
This revision was automatically updated to reflect the committed changes.
steakhal added a commit: rG813acb12972e: [analyzer][NFC] Remove unused SVal::hasConjuredSymbol.

Revision Contents

PathSize
clang/
lib/
StaticAnalyzer/
Core/
3 lines

Diff 431164

clang/lib/StaticAnalyzer/Core/SVals.cpp

Show First 20 Lines • Show All 171 Lines • ▼ Show 20 Lines
} // end anonymous namespace } // end anonymous namespace
QualType SVal::getType(const ASTContext &Context) const { QualType SVal::getType(const ASTContext &Context) const {
TypeRetrievingVisitor TRV{Context}; TypeRetrievingVisitor TRV{Context};
return TRV.Visit(*this); return TRV.Visit(*this);
} }
const MemRegion *loc::MemRegionVal::stripCasts(bool StripBaseCasts) const { const MemRegion *loc::MemRegionVal::stripCasts(bool StripBaseCasts) const {
const MemRegion *R = getRegion(); return getRegion()->StripCasts(StripBaseCasts);
return R ? R->StripCasts(StripBaseCasts) : nullptr;
} }
const void *nonloc::LazyCompoundVal::getStore() const { const void *nonloc::LazyCompoundVal::getStore() const {
return static_cast<const LazyCompoundValData*>(Data)->getStore(); return static_cast<const LazyCompoundValData*>(Data)->getStore();
} }
const TypedValueRegion *nonloc::LazyCompoundVal::getRegion() const { const TypedValueRegion *nonloc::LazyCompoundVal::getRegion() const {
return static_cast<const LazyCompoundValData*>(Data)->getRegion(); return static_cast<const LazyCompoundValData*>(Data)->getRegion();
▲ Show 20 Lines • Show All 179 Lines • Show Last 20 Lines