Page MenuHomePhabricator

[analyzer][NFC] Inline and simplify nonloc::ConcreteInt functions
AbandonedPublic

Authored by steakhal on May 21 2022, 12:09 PM.

Details

Diff Detail

Event Timeline

steakhal created this revision.May 21 2022, 12:09 PM
Herald added a project: Restricted Project. · View Herald Transcript
steakhal requested review of this revision.May 21 2022, 12:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2022, 12:09 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
martong added inline comments.May 23 2022, 4:40 AM
clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
90

I'd rather keep the switch because in D125318 we are going to extend with nonloc::SymbolValKind so, soon it will no longer be a standalone case.

steakhal abandoned this revision.May 23 2022, 5:26 AM
steakhal added inline comments.
clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
90

Okay, let's postpone this until things get settled with the unary ops stuff.