Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D126126

[analyzer][NFC] Inline and simplify nonloc::ConcreteInt functions
AbandonedPublic
Actions

Authored by steakhal on May 21 2022, 12:09 PM.

Details

Reviewers
martong
NoQ
Szelethus

Diff Detail

Event Timeline

steakhal created this revision.May 21 2022, 12:09 PM
Herald added a reviewer: Szelethus. · View Herald TranscriptMay 21 2022, 12:09 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: manas, ASDenysPetrov, dkrupp and 8 others. · View Herald Transcript
steakhal requested review of this revision.May 21 2022, 12:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2022, 12:09 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
steakhal added a parent revision: D126125: [analyzer][NFC] Inline ExprEngine::evalMinus.May 21 2022, 12:22 PM
steakhal added a child revision: D126127: [analyzer][NFC] Relocate unary transfer functions.
Harbormaster completed remote builds in B165669: Diff 431158.May 21 2022, 1:01 PM
martong added inline comments.May 23 2022, 4:40 AM
clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
90

I'd rather keep the switch because in D125318 we are going to extend with nonloc::SymbolValKind so, soon it will no longer be a standalone case.

steakhal abandoned this revision.May 23 2022, 5:26 AM
steakhal added inline comments.
clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
90

Okay, let's postpone this until things get settled with the unary ops stuff.

steakhal removed a child revision: D126127: [analyzer][NFC] Relocate unary transfer functions.May 23 2022, 6:34 AM

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
StaticAnalyzer/
Core/
PathSensitive/
4 lines
lib/
StaticAnalyzer/
Core/
10 lines
22 lines

Diff 431158

View Options

clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h

Loading...
View Options

clang/lib/StaticAnalyzer/Core/SVals.cpp

Loading...
View Options

clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp

Loading...