[mlir] Breakdown diagnostic string literals

[logan]

Summary

This commit breaks down diagnostic string literals so that the attribute
name and enumurator names can be shared with the stringify utility
function and the "expected ", " to be one of ", and ", " can be shared
between different enum-related diagnostic.

[rriddle]

I feel like I'm missing some context here, can you show some form of before/after? or is this intended to be an NFC cleanup?

[mehdi_amini]

In D125938#3533562, @rriddle wrote:

I feel like I'm missing some context here, can you show some form of before/after? or is this intended to be an NFC cleanup?

It is NFC, the point is that by splitting the string we get multiple individual char* in the binary that can be better deduped by the linked (an attribute name used in many different diagnostics for example)

[logan]

Thanks. Landed as rG57d239e4ad110c052fe0c05fb25a588ec5a8de14.

mlir/include/mlir/IR/EnumAttr.td

let parameterParser = [{[&]() -> ::mlir::FailureOr<}] # cppType # [{> {
     auto loc = $_parser.getCurrentLocation();
     ::llvm::StringRef enumKeyword;
     if (::mlir::failed($_parser.parseKeyword(&enumKeyword)))
       return ::mlir::failure();
     auto maybeEnum = }] # cppNamespace # "::" #
                           stringToSymbolFnName # [{(enumKeyword);
     if (maybeEnum)
       return *maybeEnum;
-    return {(::mlir::LogicalResult)$_parser.emitError(loc, "expected }] #
-    cppType # [{ to be one of: }] #
-    !interleave(!foreach(enum, enumerants, enum.str), ", ") # [{")};
+    return {(::mlir::LogicalResult)($_parser.emitError(loc) << "expected " }] #
+    [{<< "}] # cppType # [{" << " to be one of: " << }] #
+    !interleave(!foreach(enum, enumerants, "\"" # enum.str # "\""),
+                [{ << ", " << }]) # [{)};
   }()}];
   // Print the enum by calling `symbolToString`.
   let parameterPrinter = "$_printer << " # symbolToStringFnName # "($_self)";
 }
 
 class I32EnumAttr<string name, string summary, list<I32EnumAttrCase> cases> :
     IntEnumAttr<I32, name, summary, cases> {
   let underlyingType = "uint32_t";
let parameterParser = [{[&]() -> ::mlir::FailureOr<}] # cppType # [{> {
     auto loc = $_parser.getCurrentLocation();
     ::llvm::StringRef enumKeyword;
     do {
       if (::mlir::failed($_parser.parseKeyword(&enumKeyword)))
         return ::mlir::failure();
       auto maybeEnum = }] # cppNamespace # "::" #
                             stringToSymbolFnName # [{(enumKeyword);
       if (!maybeEnum) {
-          return {(::mlir::LogicalResult)$_parser.emitError(loc, "expected }] #
-                  cppType # [{ to be one of: }] #
-                 !interleave(!foreach(enum, enumerants, enum.str),
-                             ", ") # [{")};
+          return {(::mlir::LogicalResult)($_parser.emitError(loc) << }] #
+              [{"expected " << "}] # cppType # [{" << " to be one of: " << }] #
+              !interleave(!foreach(enum, enumerants, "\"" # enum.str # "\""),
+                          [{ << ", " << }]) # [{)};
       }
       flags = flags | *maybeEnum;
     } while(::mlir::succeeded($_parser.}] # parseSeparatorFn # [{()));
     return flags;
   }()}];
   // Print the enum by calling `symbolToString`.
   let parameterPrinter = "$_printer << " # symbolToStringFnName # "($_self)";