[mlir][LLVMIR] Use the correct way to determine if it's a scalable vector

[myhsu]

Summary

One of the ShuffleVectorOp::build functions checks if the incoming vector operands is scalable vector by casting its type to mlir::VectorType first. However, in some cases the operand is not necessarily mlir::VectorType (e.g. it might be a LLVMVectorType) so the casting will fail.

This patch fixes this issue by using the dedicated LLVM::isScalableVectorType function to determine if the incoming vector is scalable vector or not.

NOTE: Normally we will have a pure .mlir test for this kind of changes, but the affected ShuffleVectorOp::build function is not used by the MLIR parser (but used by the translator), so I only put a translator test here.

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

 // Printing/parsing for LLVM::ShuffleVectorOp.
 //===----------------------------------------------------------------------===//
 // Expects vector to be of wrapped LLVM vector type and position to be of
 // wrapped LLVM i32 type.
 void LLVM::ShuffleVectorOp::build(OpBuilder &b, OperationState &result,
                                   Value v1, Value v2, ArrayAttr mask,
                                   ArrayRef<NamedAttribute> attrs) {
   auto containerType = v1.getType();
-  auto vType = LLVM::getVectorType(
-      LLVM::getVectorElementType(containerType), mask.size(),
-      containerType.cast<VectorType>().isScalable());
+  auto vType = LLVM::getVectorType(LLVM::getVectorElementType(containerType),
+                                   mask.size(),
+                                   LLVM::isScalableVectorType(containerType));
   build(b, result, vType, v1, v2, mask);
   result.addAttributes(attrs);
 }
 
 void ShuffleVectorOp::print(OpAsmPrinter &p) {
   p << ' ' << getV1() << ", " << getV2() << " " << getMask();
   p.printOptionalAttrDict((*this)->getAttrs(), {"mask"});
   p << " : " << getV1().getType() << ", " << getV2().getType();

mlir/test/Target/LLVMIR/Import/incorrect-scalable-vector-check.ll

+; RUN: mlir-translate --import-llvm %s | FileCheck %s
+
+; CHECK: llvm.func @shufflevector_crash
+define void @shufflevector_crash(<2 x i32*> %arg0) {
+  ; CHECK: llvm.shufflevector %{{.+}}, %{{.+}} [1 : i32, 0 : i32] : !llvm.vec<2 x ptr<i32>>, !llvm.vec<2 x ptr<i32>>
+  %1 = shufflevector <2 x i32*> %arg0, <2 x i32*> undef, <2 x i32> <i32 1, i32 0>
+  ret void
+}