This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Don't use newfstatat for Linux on SPARC
ClosedPublic

Authored by glaubitz on May 13 2022, 10:58 AM.

Details

Diff Detail

Event Timeline

glaubitz created this revision.May 13 2022, 10:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2022, 10:58 AM
glaubitz requested review of this revision.May 13 2022, 10:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2022, 10:58 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
glaubitz updated this revision to Diff 429296.May 13 2022, 11:00 AM
MaskRay accepted this revision.May 14 2022, 11:37 AM
This revision is now accepted and ready to land.May 14 2022, 11:37 AM

Could someone land this for me? Thanks!

Could someone land this for me? Thanks!

Hi. I am waiting a bit for others to conform this is the direction to work around sparc64.

eugenis accepted this revision.May 16 2022, 11:09 AM

LGTM

Seems fine to me, if fstatat64 is indeed the canonical syscall on sparc.

LGTM

Seems fine to me, if fstatat64 is indeed the canonical syscall on sparc.

Yep, it is: https://github.com/torvalds/linux/commit/40ad7a6afc53217ad95b5ae2221e42d7655e057b

This revision was landed with ongoing or failed builds.May 16 2022, 12:22 PM
This revision was automatically updated to reflect the committed changes.