[FuzzMutate] Split out FuzzerCLI library that doesn't depend on IR.

[sammccall]

Summary

All llvm-project fuzzers use this library to parse command-line arguments.
Many of them don't deal with LLVM IR or modules in any way. Bundling those
functions in one library forces build dependencies that don't need to be there.

Among other things, this means check-clang-pseudo no longer depends on most of
LLVM.

[sammccall]

I'm happy to move FuzzerCLI to a separate directory (and avoid PARTIAL_SOURCES_INTENDED) if you prefer.

It's a bunch more mechanical changes and will break secondary build systems (gn, bazel), so if so let's agree on a name first.

[hokein]

This looks a reasonable split to me!

[aaron.ballman]

Sorry for the trouble, but I had to revert in a1bb952e833b34fdf03bd571e7f8c948191be018 because this broke a lot of bots:

https://lab.llvm.org/buildbot/#/builders/171/builds/14222
https://lab.llvm.org/buildbot/#/builders/188/builds/13748
https://lab.llvm.org/buildbot/#/builders/109/builds/38127

[sammccall]

Thanks for reverting, looks like I missed a target, sorry about that.

clang-tools-extra/clangd/fuzzer/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
-  FuzzMutate
+  FuzzerCLI
   Support
   )
 
 # This fuzzer runs on oss-fuzz, so keep it around even if it looks unreferenced.
 add_llvm_fuzzer(clangd-fuzzer
   clangd-fuzzer.cpp
   DUMMY_MAIN FuzzerClangdMain.cpp
   )

clang-tools-extra/pseudo/fuzzer/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
-  FuzzMutate
+  FuzzerCLI
   Support
   )
 
 add_llvm_fuzzer(clang-pseudo-fuzzer
   Fuzzer.cpp
   DUMMY_MAIN Main.cpp
   )
 
 target_link_libraries(clang-pseudo-fuzzer
   PRIVATE
   clangPseudo
   )

clang/tools/clang-fuzzer/CMakeLists.txt

-set(LLVM_LINK_COMPONENTS ${LLVM_TARGETS_TO_BUILD} FuzzMutate)
+set(LLVM_LINK_COMPONENTS ${LLVM_TARGETS_TO_BUILD} FuzzerCLI)
 set(CXX_FLAGS_NOFUZZ ${CMAKE_CXX_FLAGS})
 set(DUMMY_MAIN DummyClangFuzzer.cpp)
 if(LLVM_LIB_FUZZING_ENGINE)
   unset(DUMMY_MAIN)
 elseif(LLVM_USE_SANITIZE_COVERAGE)
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=fuzzer")
   set(CXX_FLAGS_NOFUZZ "${CXX_FLAGS_NOFUZZ} -fsanitize=fuzzer-no-link")
   unset(DUMMY_MAIN)

llvm/lib/FuzzMutate/CMakeLists.txt

-add_llvm_component_library(LLVMFuzzMutate
+# Generic helper for fuzzer binaries.
+# This should not depend on LLVM IR etc.
+add_llvm_component_library(LLVMFuzzerCLI
   FuzzerCLI.cpp
+  PARTIAL_SOURCES_INTENDED
+
+  ADDITIONAL_HEADER_DIRS
+  ${LLVM_MAIN_INCLUDE_DIR}/llvm/FuzzMutate
+
+  LINK_COMPONENTS
+  Support
+  )
+
+# Library for using LLVM IR together with fuzzers.
+add_llvm_component_library(LLVMFuzzMutate
   IRMutator.cpp
   OpDescriptor.cpp
   Operations.cpp
   RandomIRBuilder.cpp
+  PARTIAL_SOURCES_INTENDED
 
   ADDITIONAL_HEADER_DIRS
   ${LLVM_MAIN_INCLUDE_DIR}/llvm/FuzzMutate
 
   DEPENDS
   intrinsics_gen
 
   LINK_COMPONENTS
   Analysis
   BitReader
   BitWriter
   Core
   Scalar
   Support
   Target
   )

llvm/tools/llvm-dlang-demangle-fuzzer/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   Demangle
-  FuzzMutate
+  FuzzerCLI
   Support
 )
 
 add_llvm_fuzzer(llvm-dlang-demangle-fuzzer
   llvm-dlang-demangle-fuzzer.cpp
   DUMMY_MAIN DummyDemanglerFuzzer.cpp
   )

llvm/tools/llvm-isel-fuzzer/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
     AllTargetsAsmParsers
     AllTargetsCodeGens
     AllTargetsDescs
     AllTargetsInfos
     Analysis
     AsmPrinter
     BitReader
     BitWriter
     CodeGen
     Core
+    FuzzerCLI
     FuzzMutate
     IRReader
     MC
     ScalarOpts
     SelectionDAG
     Support
     Target
 )
 add_llvm_fuzzer(llvm-isel-fuzzer
   llvm-isel-fuzzer.cpp
   DUMMY_MAIN DummyISelFuzzer.cpp
   )

llvm/tools/llvm-itanium-demangle-fuzzer/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   Demangle
-  FuzzMutate
+  FuzzerCLI
   Support
 )
 
 add_llvm_fuzzer(llvm-itanium-demangle-fuzzer
   llvm-itanium-demangle-fuzzer.cpp
   DUMMY_MAIN DummyDemanglerFuzzer.cpp
   )

llvm/tools/llvm-microsoft-demangle-fuzzer/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   Demangle
-  FuzzMutate
+  FuzzerCLI
   Support
 )
 
 add_llvm_fuzzer(llvm-microsoft-demangle-fuzzer
   llvm-microsoft-demangle-fuzzer.cpp
   DUMMY_MAIN DummyDemanglerFuzzer.cpp
   )

llvm/tools/llvm-opt-fuzzer/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   AllTargetsAsmParsers
   AllTargetsCodeGens
   AllTargetsDescs
   AllTargetsInfos
   Analysis
   BitReader
   BitWriter
   CodeGen
   Core
   Coroutines
   IPO
   IRReader
   AggressiveInstCombine
   InstCombine
   Instrumentation
+  FuzzerCLI
   FuzzMutate
   MC
   ObjCARCOpts
   ScalarOpts
   Support
   Target
   TransformUtils
   Vectorize
   Passes
 )
 
 add_llvm_fuzzer(llvm-opt-fuzzer
   llvm-opt-fuzzer.cpp
   DUMMY_MAIN DummyOptFuzzer.cpp
   )

llvm/tools/llvm-rust-demangle-fuzzer/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   Demangle
-  FuzzMutate
+  FuzzerCLI
   Support
 )
 
 add_llvm_fuzzer(llvm-rust-demangle-fuzzer
   llvm-rust-demangle-fuzzer.cpp
   DUMMY_MAIN DummyDemanglerFuzzer.cpp
   )

llvm/tools/llvm-special-case-list-fuzzer/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   Support
-  FuzzMutate
+  FuzzerCLI
 )
 
 add_llvm_fuzzer(llvm-special-case-list-fuzzer
   special-case-list-fuzzer.cpp
   DUMMY_MAIN DummySpecialCaseListFuzzer.cpp
   )

llvm/tools/llvm-yaml-numeric-parser-fuzzer/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   Support
-  FuzzMutate
+  FuzzerCLI
 )
 
 add_llvm_fuzzer(llvm-yaml-numeric-parser-fuzzer
   yaml-numeric-parser-fuzzer.cpp
   DUMMY_MAIN DummyYAMLNumericParserFuzzer.cpp
   )

mlir/tools/mlir-parser-fuzzer/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
-  FuzzMutate
+  FuzzerCLI
   Support
 )
 add_llvm_fuzzer(mlir-parser-fuzzer
   mlir-parser-fuzzer.cpp
   DUMMY_MAIN DummyParserFuzzer.cpp
 )
 target_link_libraries(mlir-parser-fuzzer
   PUBLIC
   MLIRIR
   MLIRParser
   MLIRSupport
 )