[BOLT][TEST] Fix test failures on AArch64 builder

[Amir]

Summary

Address X86 tests failures on AArch64 builder:
https://lab.llvm.org/staging/#/builders/211/builds/82

Inputs fail to cross-compile due to a missing header:

/usr/include/stdio.h:27:10: fatal error: 'bits/libc-header-start.h' file not found
#include <bits/libc-header-start.h>

As inputs are linked with -nostdlib anyway, don't include stdio.h.

[yota9]

bolt/test/X86/Inputs/avx512.c

8

I have the same error in golang review, maybe it warnings about this new line, although I'm not sure what is going on with it on my review too :(

[Amir]

clang-format

[Amir]

bolt/test/X86/Inputs/avx512.c

8

Apparently clang-format was complaining about the space in second asm() line.

[Amir]

This change breaks testing with an upstream clang:

/home/worker/bolt-worker2/bolt-x86_64-ubuntu-bolttests/llvm-project/bolt/test/Inputs/icf-jump-tables.c:3:13: error: call to undeclared function 'puts'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

Reverted the change for now, will figure out the proper fix and re-land.

[Amir]

Fix build with upstream clang

[yota9]

@Amir Consider to add puts to stub.h and include the header

[Amir]

Move puts to stub.h

[Amir]

In D124863#3489705, @yota9 wrote:

@Amir Consider to add puts to stub.h and include the header

Thanks for a suggestion!

bolt/test/Inputs/icf-jump-tables.c

-#include <stdio.h>
+#include "stub.h"
 
 int inc(int x) {
   switch (x) {
     case 0: puts("0"); return 1;
     case 1: puts("1"); return 2;
     case 2: puts("2"); return 3;
     case 3: puts("3"); return 4;
     case 4: puts("4"); return 5;

bolt/test/Inputs/stub.h

 #ifndef BOLT_TEST_STUB_H
 #define BOLT_TEST_STUB_H
 
 void *memcpy(void *dest, const void *src, unsigned long n);
 void *memset(void *dest, int c, unsigned long n);
 int printf(const char *format, ...);
 void exit(int status);
+int puts(const char *s);
 
 #endif

bolt/test/Inputs/stub.c

 // The stub symbols library used for testing purposes
 
 void *memcpy(void *dest, const void *src, unsigned long n) { return 0; }
 void *memset(void *dest, int c, unsigned long n) { return 0; }
 int printf(const char *format, ...) { return 0; }
 void exit(int status) {}
+int puts(const char *s) { return 0; }
 
 void *__gxx_personality_v0;
 void *__cxa_allocate_exception;
 void *_ZTIi;
 void *__cxa_throw;
 void *__cxa_begin_catch;
 void *__cxa_end_catch;

bolt/test/X86/Inputs/avx512.c

-#include <stdio.h>
-
 void use_avx512() {
-  printf("after first entry\n");
   asm (".byte 0x62, 0xe2, 0xf5, 0x70, 0x2c, 0xda");
-  asm ("secondary_entry:");
-  printf("after secondary entry\n");
+  asm("secondary_entry:");
 }
 
 int main() {
-  printf("about to use avx-512 instruction...\n");
   use_avx512();
 
   return 0;
 }

bolt/test/X86/Inputs/inline-foo.c

-#include <stdio.h>
+#include "stub.h"
 
 void foo() {
   puts("Hello world!\n");
 }

bolt/test/X86/inline-debug-info.test

 ## Check that BOLT correctly prints and updates debug info for inlined
 ## functions.
 
 # REQUIRES: system-linux
 
 # RUN: %clang %cflags -O1 -g %p/Inputs/inline-main.c %p/Inputs/inline-foo.c \
-# RUN:   -o %t.exe -Wl,-q
+# RUN:   -I%p/../Inputs -o %t.exe -Wl,-q
 # RUN: llvm-bolt %t.exe -update-debug-sections -print-debug-info \
 # RUN:   -print-only=main -print-after-lowering -force-inline=foo -o %t.bolt \
 # RUN:   | FileCheck %s
 
 ## The call to puts() should come from inline-foo.c:
 # CHECK: callq   {{.*}} # debug line {{.*}}inline-foo.c:4:3
 
 # RUN: llvm-objdump --disassemble-symbols=main -d --line-numbers %t.bolt \
 # RUN:   | FileCheck %s -check-prefix=CHECK-OBJDUMP
 
 ## Dump of main() should include debug info from inline-foo.c after inlining:
 # CHECK-OBJDUMP: inline-foo.c:4