Details
Diff Detail
Event Timeline
Thanks!
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | ||
---|---|---|
1553 | Not sure why the comment mentions gfx8. Even on later archs the requirement is for 16-byte alignment if you set strict alignment mode. |
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | ||
---|---|---|
1553 | I left it as is, but it suggests on VI this was required even with unaligned access enabled. From my recollections this is not true, but I would not bet on it until I dig the specs. Moreover, I believe unaligned access was legal with a proper setting since CI, but that needs a doc excavations. I would have to dig around the shelve to find a Bonaire or Fiji to check, so I just left it as is for now. This is really something like a couple days of work to check with a little benefit. |
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | ||
---|---|---|
1553 |
Understood! :) |
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | ||
---|---|---|
1553 | Moreover, I shall have Fiji around, Bonaire in a radius of 60 miles and I don't even remember if I have a Tahiti handy anywhere. Too much for fixing someone's comment ;) |
Not sure why the comment mentions gfx8. Even on later archs the requirement is for 16-byte alignment if you set strict alignment mode.