This is an archive of the discontinued LLVM Phabricator instance.

Differential D123415

[lldb] Fix crash when a type has no definition
AbandonedPublic

Authored by siggi-alpheus on Apr 8 2022, 11:13 AM.

Details

Reviewers
labath
jasonmolenda
shafik
Summary

See issue 54761.
It looks like Google Chrome's symbols contain some member functions whose this pointer type is missing, which causes a nullptr access and a crash. This patch makes lldb tolerant of this problem by avoiding the nullptr access.

Diff Detail

Event Timeline

siggi-alpheus created this revision.Apr 8 2022, 11:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2022, 11:13 AM
Herald added a subscriber: JDevlieghere. · View Herald Transcript
siggi-alpheus requested review of this revision.Apr 8 2022, 11:13 AM
Herald added a subscriber: lldb-commits. · View Herald TranscriptApr 8 2022, 11:13 AM
Harbormaster completed remote builds in B158750: Diff 421592.Apr 8 2022, 11:16 AM
JDevlieghere added a reviewer: shafik.Apr 8 2022, 11:16 AM
siggi-alpheus abandoned this revision.May 2 2022, 8:43 AM

This is not a good fix for the crash. A better fix is in https://reviews.llvm.org/D124370.

Revision Contents

PathSize
lldb/
source/
Plugins/
TypeSystem/
Clang/
3 lines

Diff 421592

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

Context not available.
clang::CXXRecordDecl *cxx_record_decl = clang::CXXRecordDecl *cxx_record_decl =
record_qual_type->getAsCXXRecordDecl(); record_qual_type->getAsCXXRecordDecl();
if (cxx_record_decl == nullptr) // Bail if no declaration or if the declaration has no definition.
if (cxx_record_decl == nullptr || !cxx_record_decl->hasDefinition())
return nullptr; return nullptr;
clang::QualType method_qual_type(ClangUtil::GetQualType(method_clang_type)); clang::QualType method_qual_type(ClangUtil::GetQualType(method_clang_type));
Context not available.