This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Fix handling of gfx10 LDS misaligned access bug
ClosedPublic

Authored by rampitec on Apr 7 2022, 1:40 PM.

Details

Summary

It was only handled for FLAT initially because we did not have
unaligned DS instructions lowering. Now it is implemented but
the bug is not handled.

Diff Detail

Event Timeline

rampitec created this revision.Apr 7 2022, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2022, 1:40 PM
rampitec requested review of this revision.Apr 7 2022, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2022, 1:40 PM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm added inline comments.Apr 7 2022, 2:09 PM
llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-load-local-128.mir
4

Should this get a runline with and without cumode?

rampitec added inline comments.Apr 7 2022, 2:13 PM
llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-load-local-128.mir
4

It does not make sense, this must be legalized and test only runs selector.
But since it is not legal I would have to add -disable-gisel-legality-check and the test would become a no-op.
The relevant test is legalizer.

arsenm accepted this revision.Apr 7 2022, 2:44 PM
This revision is now accepted and ready to land.Apr 7 2022, 2:44 PM
This revision was landed with ongoing or failed builds.Apr 7 2022, 3:08 PM
This revision was automatically updated to reflect the committed changes.