Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Transforms/Utils/BuildLibCalls.cpp | ||
---|---|---|
460 | I just looked at this again, and while this does actually end up doing the right thing, I think it's very subtle. It would be better to rewrite this like so (without the separate fallthrough): Changed |= setAllocFamility(F, TheLibFunc == LibFunc_vec_malloc ? "vec_malloc" : "malloc"); It also looks like we currently don't have tests for the vec_malloc case. |
I just looked at this again, and while this does actually end up doing the right thing, I think it's very subtle. It would be better to rewrite this like so (without the separate fallthrough):
It also looks like we currently don't have tests for the vec_malloc case.