Details
Details
- Reviewers
jdoerfert Mordante - Group Reviewers
Restricted Project - Commits
- rG9a44ed43cf9a: [libc++] Implement tests for private headers using the new generator
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Nice cleanup, thanks a lot!
Just curious how did you remove the no longer needed files? I'm asking since I expect some new obsolete files might be added by reviews in progress.
LGTM once the CI is happy.
libcxx/test/libcxx/private_headers.verify.cpp | ||
---|---|---|
27 | guess we need to guard this expected-error from being processed in lit. |
Comment Actions
I just did rm -rf libcxx/test/libcxx/diagnostics/detail.headers, since I think that's where all the old tests used to live. I'll do it again before landing, and folks should rebase their patches after I land this as well.
libcxx/test/libcxx/private_headers.verify.cpp | ||
---|---|---|
27 | Indeed, thanks! This escaping is a little bit annoying, but I guess it's not the end of the world. |
guess we need to guard this expected-error from being processed in lit.