This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Implement tests for private headers using the new generator
ClosedPublic

Authored by ldionne on Apr 4 2022, 6:17 AM.

Diff Detail

Event Timeline

ldionne created this revision.Apr 4 2022, 6:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 6:17 AM
ldionne requested review of this revision.Apr 4 2022, 6:17 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision.Apr 4 2022, 9:11 AM
Mordante added a subscriber: Mordante.

Nice cleanup, thanks a lot!

Just curious how did you remove the no longer needed files? I'm asking since I expect some new obsolete files might be added by reviews in progress.

LGTM once the CI is happy.

libcxx/test/libcxx/private_headers.verify.cpp
27

guess we need to guard this expected-error from being processed in lit.

This revision is now accepted and ready to land.Apr 4 2022, 9:11 AM
ldionne marked an inline comment as done.Apr 4 2022, 11:10 AM

Nice cleanup, thanks a lot!

Just curious how did you remove the no longer needed files? I'm asking since I expect some new obsolete files might be added by reviews in progress.

I just did rm -rf libcxx/test/libcxx/diagnostics/detail.headers, since I think that's where all the old tests used to live. I'll do it again before landing, and folks should rebase their patches after I land this as well.

libcxx/test/libcxx/private_headers.verify.cpp
27

Indeed, thanks! This escaping is a little bit annoying, but I guess it's not the end of the world.

ldionne updated this revision to Diff 420249.Apr 4 2022, 11:10 AM
ldionne marked an inline comment as done.

Try to fix the modular CI issue

libcxx/utils/generate_header_tests.py