This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy][docs] Add --update-section to objcopy command guide
ClosedPublic

Authored by gbreynoo on Apr 1 2022, 7:59 AM.

Details

Summary

I noticed that when --update-section was added to llvm-objcopy it was not added to the command guide, see 25bcd94234530955c58c6530a9271c813827637c. This change adds it to the docs.

Diff Detail

Event Timeline

gbreynoo created this revision.Apr 1 2022, 7:59 AM
gbreynoo requested review of this revision.Apr 1 2022, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2022, 7:59 AM
MaskRay accepted this revision.Apr 1 2022, 8:29 AM
This revision is now accepted and ready to land.Apr 1 2022, 8:29 AM
abrachet added inline comments.Apr 1 2022, 8:31 AM
llvm/docs/CommandGuide/llvm-objcopy.rst
222

I don't think --update-section will add a section if it doesn't exist. It just updates the contents of an existing section. Might also be worth mentioning that it must be the same size or smaller.

gbreynoo updated this revision to Diff 419782.Apr 1 2022, 9:16 AM

Fixed the description after abrachet's comment and updated the help output to mirror the change.

gbreynoo added inline comments.Apr 1 2022, 9:17 AM
llvm/docs/CommandGuide/llvm-objcopy.rst
222

Good catch @abrachet, I've updated the description.

jhenderson accepted this revision.Apr 4 2022, 12:37 AM

LGTM, but mention the help text fix in the commit message too, please.

This revision was landed with ongoing or failed builds.Apr 4 2022, 8:23 AM
This revision was automatically updated to reflect the committed changes.