This is an archive of the discontinued LLVM Phabricator instance.

[NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum
ClosedPublic

Authored by lenary on Mar 30 2022, 10:08 AM.

Diff Detail

Event Timeline

lenary created this revision.Mar 30 2022, 10:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 10:08 AM
lenary requested review of this revision.Mar 30 2022, 10:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 10:08 AM
dmgreen accepted this revision.Mar 31 2022, 1:13 AM

Tests are always good - LGTM

This revision is now accepted and ready to land.Mar 31 2022, 1:13 AM
lenary updated this revision to Diff 421191.Apr 7 2022, 6:56 AM
  • Added additional float and call tests.
lenary updated this revision to Diff 428975.May 12 2022, 9:37 AM
  • Rebase
lenary updated this revision to Diff 428977.May 12 2022, 9:39 AM
  • Upload correct patch.

The test file has 4000+ lines. Any chance making it smaller?

I want to keep the number of llvm functions the same, as they cover a wide variety of control flow at a wide variety of data widths which the pass should cope with.

One thing that I would like to cut down is the duplicated set of CHECK lines, one with scheduling and one without, but I'm not sure how to do that (the set with scheduling are there to test that -mcpu=cortex-a55 enables the pass, I'm not sure of a better way of doing the same.

I want to keep the number of llvm functions the same, as they cover a wide variety of control flow at a wide variety of data widths which the pass should cope with.

One thing that I would like to cut down is the duplicated set of CHECK lines, one with scheduling and one without, but I'm not sure how to do that (the set with scheduling are there to test that -mcpu=cortex-a55 enables the pass), I'm not sure of a better way of doing the same.

After a quick look, I can confirm that the ARM Backend seems to disregard tune-cpu metadata, the subtarget is initialized with TuneCPU equal to CPU, which makes this difficult. Still investigating whether --enable-misched=false will be enough.

I spent some time last night trying to work out if a combination of --enable-misched=false --pre-RA-sched=linearize -disable-post-ra -enable-post-misched=false would help avoid having two sets of match lines, and none seemed to. @MaskRay as I can't find a quick way of making it smaller, and the patch these tests are for has been approved, I'm going to land this as-is. I hope that is ok.

This revision was landed with ongoing or failed builds.May 13 2022, 2:41 AM
This revision was automatically updated to reflect the committed changes.