[X86] Rename MMX_MOVD64from64rm to MMX_MOVD64from64mr b/c it stores sth, NFC

[xiangzhangllvm]

Just correct the opcode's name ?

[skan]

In D122216#3398936, @xiangzhangllvm wrote:

Just correct the opcode's name ?

Yes. A simple fix.

[pengfei]

LGTM. Are there any similar cases? I think we can detect it by tool through the dump from -print-records, further more, we can check from TableGen directly.

[skan]

In D122216#3399028, @pengfei wrote:

LGTM. Are there any similar cases? I think we can detect it by tool through the dump from -print-records, further more, we can check from TableGen directly.

I haven't found more yet. It occurs to me when I am fixing the memory folding table...

[RKSimon]

LGTM - cheers

llvm/lib/Target/X86/X86SchedSandyBridge.td

819

The fact that this is a store makes me suspicious that it shouldn't be with all these loads - I'll take a look at it.

llvm/lib/Target/X86/X86InstrFoldTables.cpp

static const X86MemoryFoldTableEntry MemoryFoldTable2Addr[] = {
   { X86::XOR64ri8,    X86::XOR64mi8,   0 },
   { X86::XOR64rr,     X86::XOR64mr,    0 },
   { X86::XOR8ri,      X86::XOR8mi,     0 },
   { X86::XOR8ri8,     X86::XOR8mi8,    0 },
   { X86::XOR8rr,      X86::XOR8mr,     0 },
 };
 
 static const X86MemoryFoldTableEntry MemoryFoldTable0[] = {
   { X86::BT16ri8,             X86::BT16mi8,             TB_FOLDED_LOAD },
   { X86::BT32ri8,             X86::BT32mi8,             TB_FOLDED_LOAD },
   { X86::BT64ri8,             X86::BT64mi8,             TB_FOLDED_LOAD },
   { X86::CALL16r,             X86::CALL16m,             TB_FOLDED_LOAD },
   { X86::CALL16r_NT,          X86::CALL16m_NT,          TB_FOLDED_LOAD },
   { X86::CALL32r,             X86::CALL32m,             TB_FOLDED_LOAD },
   { X86::CALL32r_NT,          X86::CALL32m_NT,          TB_FOLDED_LOAD },
   { X86::CALL64r,             X86::CALL64m,             TB_FOLDED_LOAD },
   { X86::CALL64r_NT,          X86::CALL64m_NT,          TB_FOLDED_LOAD },
static const X86MemoryFoldTableEntry MemoryFoldTable0[] = {
   { X86::IMUL64r,             X86::IMUL64m,             TB_FOLDED_LOAD },
   { X86::IMUL8r,              X86::IMUL8m,              TB_FOLDED_LOAD },
   { X86::JMP16r,              X86::JMP16m,              TB_FOLDED_LOAD },
   { X86::JMP16r_NT,           X86::JMP16m_NT,           TB_FOLDED_LOAD },
   { X86::JMP32r,              X86::JMP32m,              TB_FOLDED_LOAD },
   { X86::JMP32r_NT,           X86::JMP32m_NT,           TB_FOLDED_LOAD },
   { X86::JMP64r,              X86::JMP64m,              TB_FOLDED_LOAD },
   { X86::JMP64r_NT,           X86::JMP64m_NT,           TB_FOLDED_LOAD },
-  { X86::MMX_MOVD64from64rr,  X86::MMX_MOVD64from64rm,  TB_FOLDED_STORE | TB_NO_REVERSE },
+  { X86::MMX_MOVD64from64rr,  X86::MMX_MOVD64from64mr,  TB_FOLDED_STORE | TB_NO_REVERSE },
   { X86::MMX_MOVD64grr,       X86::MMX_MOVD64mr,        TB_FOLDED_STORE | TB_NO_REVERSE },
   { X86::MOV16ri,             X86::MOV16mi,             TB_FOLDED_STORE },
   { X86::MOV16rr,             X86::MOV16mr,             TB_FOLDED_STORE },
   { X86::MOV32ri,             X86::MOV32mi,             TB_FOLDED_STORE },
   { X86::MOV32rr,             X86::MOV32mr,             TB_FOLDED_STORE },
   { X86::MOV64ri32,           X86::MOV64mi32,           TB_FOLDED_STORE },
   { X86::MOV64rr,             X86::MOV64mr,             TB_FOLDED_STORE },
   { X86::MOV64toSDrr,         X86::MOV64mr,             TB_FOLDED_STORE | TB_NO_REVERSE },

llvm/lib/Target/X86/X86InstrMMX.td

def MMX_MOVQ64rr_REV : MMXI<0x7F, MRMDestReg, (outs VR64:$dst), (ins VR64:$src),
                             FoldGenData<"MMX_MOVQ64rr">;
 } // SchedRW, hasSideEffects, isMoveReg
 } // isBitcast
 
 def : InstAlias<"movq.s\t{$src, $dst|$dst, $src}",
                 (MMX_MOVQ64rr_REV VR64:$dst, VR64:$src), 0>;
 
 let isCodeGenOnly = 1, ForceDisassemble = 1, hasSideEffects = 0, mayStore = 1 in
-def MMX_MOVD64from64rm : MMXRI<0x7E, MRMDestMem,
+def MMX_MOVD64from64mr : MMXRI<0x7E, MRMDestMem,
                                (outs), (ins i64mem:$dst, VR64:$src),
                                "movq\t{$src, $dst|$dst, $src}", []>,
                                Sched<[SchedWriteVecMoveLS.MMX.MR]>;
 
 let SchedRW = [SchedWriteVecMoveLS.MMX.RM] in {
 let canFoldAsLoad = 1 in
 def MMX_MOVQ64rm : MMXI<0x6F, MRMSrcMem, (outs VR64:$dst), (ins i64mem:$src),
                         "movq\t{$src, $dst|$dst, $src}",

llvm/lib/Target/X86/X86SchedSandyBridge.td

 }
 def: InstRW<[SBWriteResGroup47], (instregex "FXRSTOR")>;
 
 def SBWriteResGroup48 : SchedWriteRes<[SBPort23]> {
   let Latency = 6;
   let NumMicroOps = 1;
   let ResourceCycles = [1];
 }
-def: InstRW<[SBWriteResGroup48], (instrs MMX_MOVD64from64rm,
+def: InstRW<[SBWriteResGroup48], (instrs MMX_MOVD64from64mr,
                                          VBROADCASTSSrm)>;
 def: InstRW<[SBWriteResGroup48], (instregex "POP(16|32|64)r",
                                             "(V?)MOV64toPQIrm",
                                             "(V?)MOVDDUPrm",
                                             "(V?)MOVDI2PDIrm",
                                             "(V?)MOVQI2PQIrm",
                                             "(V?)MOVSDrm",
                                             "(V?)MOVSHDUPrm",